extract example_lines to module level, add write_lines unittests

supercoderhawk · supercoderhawk · commit 29f7c210e225 · 2019-06-20T14:45:03.000+08:00
diff --git a/tests/io/test_file.py b/tests/io/test_file.py
@@ -1,42 +1,60 @@
 # -*- coding: UTF-8 -*-
+import tempfile
+import pytest
 from pysenal.io.file import *
 from tests import TEST_DATA_DIR
 
 
-def test_read_lines():
+@pytest.fixture("module")
+def example_lines():
+    lines = ['This is an example.   ',
+             'This is a different example.',
+             '',
+             '    Hahaha.']
+    return lines
+
+
+def test_read_lines(example_lines):
     filename = TEST_DATA_DIR + 'a.txt'
     lines = read_lines(filename)
-    true_lines = ['This is an example.   ',
-                  'This is a different example.',
-                  '',
-                  '    Hahaha.']
-    assert lines == true_lines
+    assert lines == example_lines
     skip_lines = read_lines(filename, skip_empty=True)
-    assert skip_lines == [l for l in true_lines if l]
+    assert skip_lines == [l for l in example_lines if l]
     assert read_lines(TEST_DATA_DIR + 'a.txt.gbk', 'gbk') == ['&#20320;&#22909;', '&#36825;&#26159;&#19968;&#20010;&#20363;&#23376;&#12290;']
 
 
-def test_read():
+def test_read(example_lines):
     filename = TEST_DATA_DIR + 'a.txt'
     text = read_file(filename)
-    true_text = "This is an example.   \nThis is a different example.\n\n    Hahaha."
+    true_text = '\n'.join(example_lines)
     assert text == true_text
 
 
 def test_read_json():
     read_json(TEST_DATA_DIR + 'a.json')
 
 
-def test_text_file():
-    true_text = "This is an example.   \nThis is a different example.\n\n    Hahaha."
+def test_write_lines(example_lines):
+    dirname = tempfile.gettempdir() + '/'
+    filename = dirname + 'a.txt'
+    if os.path.exists(filename):
+        os.remove(filename)
+
+    write_lines(filename, example_lines)
+    with open(filename) as f:
+        assert f.read().splitlines() == example_lines
+
+    if os.path.exists(filename):
+        os.remove(filename)
+
+
+def test_text_file(example_lines):
+    true_text = '\n'.join(example_lines)
     text_file = TextFile(TEST_DATA_DIR + 'a.txt')
     text = text_file.read()
     lines = text_file.read_lines()
     assert text == true_text
-    assert lines == ['This is an example.',
-                     'This is a different example.',
-                     '',
-                     'Hahaha.']
+    assert lines == example_lines
     expected_write_text = 'New Example\n\n'
     text_file.write(expected_write_text)
     print(text_file.read())
@@ -46,4 +64,4 @@ def test_text_file():
     expected_write_lines = ['A', '', 'BBB', 'C']
     assert text_file.read_lines() == expected_write_lines
 
-    text_file.write(true_text)
+    text_file.write(true_text)
