Open
Description
Describe the bug
Exits with TypeError: Cannot read property 'call' of null when run against (at least) my website using -r.
See full log
# ./bin/blc --filter-level 3 -r https://dbogatov.org
Starting recursive scan...
Getting links from: https://dbogatov.org/
Getting links from: https://dbogatov.org/
TypeError: Cannot read property 'isAllowed' of null
======================
Links found: 0
Links skipped: 0
Links OK: 0
Links broken: 0
Time elapsed: 1 second
======================
├───OK─── https://www.googletagmanager.com/gtag/js?id=UA-65293382-4
Finished! 1 links found. 0 broken.
TypeError: Cannot read property 'call' of null
at HtmlUrlChecker._completedPage2 (/broken-link-checker/lib-cjs/public/HtmlUrlChecker.js:264:44)
at HtmlChecker.<anonymous> (/broken-link-checker/lib-cjs/public/HtmlUrlChecker.js:142:407)
at HtmlChecker.emit (events.js:315:20)
at HtmlChecker.emit (/broken-link-checker/lib-cjs/internal/SafeEventEmitter.js:20:13)
at HtmlChecker._complete2 (/broken-link-checker/lib-cjs/public/HtmlChecker.js:211:8)
at UrlChecker.<anonymous> (/broken-link-checker/lib-cjs/public/HtmlChecker.js:99:395)
at UrlChecker.emit (events.js:315:20)
at UrlChecker.emit (/broken-link-checker/lib-cjs/internal/SafeEventEmitter.js:20:13)
at RequestQueue.<anonymous> (/broken-link-checker/lib-cjs/public/UrlChecker.js:68:54)
at RequestQueue.emit (events.js:315:20)
at RequestQueue._removeItem2 (/broken-link-checker/node_modules/limited-request-queue/lib-es5/index.js:373:65)
at /broken-link-checker/node_modules/limited-request-queue/lib-es5/index.js:303:63
at RequestQueue.<anonymous> (/broken-link-checker/lib-cjs/public/UrlChecker.js:67:7)
at processTicksAndRejections (internal/process/task_queues.js:97:5)To Reproduce
Here is what I did:
$ docker run -it node:14.3.0-alpine3.10 /bin/sh
apk add --update bash git
git clone https://github.com/stevenvachon/broken-link-checker.git
cd broken-link-checker/
npm install
npm run build
# here is the call
./bin/blc --filter-level 3 -r https://dbogatov.orgExpected behavior
Earlier versions (e.g. v0.7.x) work fine.
For the record, the reason I tried to switch to v8 is because all of sudden earlier versions started to dislike perfectly fine SSL certificates...
Environment:
- OS and version:
node:14.3.0-alpine3.10 /bin/shDocker image - Node.js version: 14.0.3
- broken-link-checker version: built from master (a08abcd)
Activity