[PARTNER-329] SEP-6/24: Add new user_action_required_by transaction field
#1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CassioMG
reviewed
May 8, 2024
JakeUrban
reviewed
May 8, 2024
Ifropc
changed the title
action_required_by transaction fielduser_action_required_by transaction field
JakeUrban
approved these changes
May 8, 2024
This was referenced May 14, 2024
Ifropc
added a commit
to stellar/anchor-platform
that referenced
this pull request
May 17, 2024
### Description - Add new field `user_action_required_by` to SEP-6/24/31 transactions and related DB entries. - Added configuration option for SEP-6 and SEP-24 to set initial value on transaction creation. - Added support for related RPC requests to update this field. - Added ability to query platform transactions sorted by `user_action_required_by` field ### Context Implements stellar/stellar-protocol#1484 ### Testing - `./gradlew test` - New test cases covering all new features ### Documentation https://stellarorg.atlassian.net/browse/ANCHOR-688 https://stellarorg.atlassian.net/browse/ANCHOR-704 ### Known limitations N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional
user_action_required_byfield. This field should be used to show the time anchors gives for the user to make an action before transaction will automatically expire or be refunded. In certain statuses, such aspending_user_transfer_startorincomplete, anchor waits for the user before advancing transaction to the next status. Using newuser_action_required_byfield, anchor indicates the deadline of the action to take place. Anchor should specify the action waited on usingmessageormore_info_url.user_action_required_byshould only be set for the statuses that will lead to anchor automatically setting transaction to the next status (such asexpired/refunded) once the deadline is reached, and should be not set (or set tonull) in all other cases.Also added missed on_hold field to SEP-6 transaction