-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEP-6: Make account_id
optional in withdraw response
#1417
Conversation
2cec6e3
to
8b2e915
Compare
I'm not sure we want to move forward this with this. Ideally, This is a bug, since
|
Actually, I misspoke when I said the Anchor Platform will never return the success response (it will). So now I see the problem.. the Anchor Platform's implementation has a bug but we can't fix it without potentially breaking business's application logic. At the same time, allowing businesses to update So I've come full circle now 😅 and think making |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the description of the responses too?
This is the correct response if the anchor is able to execute the withdrawal and needs no additional information about the user.
This isn't actually true now. This probably shouldn't be considered a "success" response since its possible for the business to request KYC info after returning 200 and the transaction's ID.
Lets update the deposit response description too if it has the same issue.
@JakeUrban Thanks for catching that, I made the changes 👍 |
This makes the
account_id
field in thewithdraw
andwithdraw-exchange
response optional. This is to support Anchors integrating with a Custodian, in which a Stellar address other than the asset's distribution account is used as thewithdraw_anchor_account
. This is to prevent users from accidentally depositing to the wrong address in case thewithdraw_anchor_account
is changed during the SEP transaction's lifecycle.