Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEP-6: add firm quote withdrawal mermaid diagram #1147

Merged
merged 4 commits into from
Mar 17, 2022
Merged

SEP-6: add firm quote withdrawal mermaid diagram #1147

merged 4 commits into from
Mar 17, 2022

Conversation

JakeUrban
Copy link
Contributor

@JakeUrban JakeUrban commented Mar 16, 2022 •
edited
Loading

Adds a sequence diagram to the SEP-6 protocol documenting a withdrawal flow, specifically for using SEP-38 firm quotes.

This flow is very similar to the SEP-31 diagram added in #1145.

@JakeUrban JakeUrban marked this pull request as ready for review March 16, 2022 16:03
leighmcculloch
leighmcculloch reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻 One typo (🔡), and one thought (💭) that I defer to you on if you think is meaningful.

ecosystem/sep-0006.md Outdated Show resolved Hide resolved
ecosystem/sep-0006.md Outdated Show resolved Hide resolved
JakeUrban and others added 2 commits March 17, 2022 10:03
@JakeUrban @leighmcculloch
Update ecosystem/sep-0006.md
06e1608 
Co-authored-by: Leigh McCulloch <[email protected]>
@JakeUrban @leighmcculloch
Update ecosystem/sep-0006.md
1a4399d 
Co-authored-by: Leigh McCulloch <[email protected]>
@JakeUrban JakeUrban merged commit 349a224 into master Mar 17, 2022
@JakeUrban JakeUrban deleted the add-sep6-diagram branch March 17, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakeUrban @leighmcculloch