Skip to content
This repository has been archived by the owner on Nov 11, 2024. It is now read-only.

feat(lang): Add Vietnamese #1265

Merged
merged 5 commits into from
Aug 29, 2023
Merged

feat(lang): Add Vietnamese #1265

merged 5 commits into from
Aug 29, 2023

Conversation

hmz121
Copy link
Contributor

@hmz121 hmz121 commented Aug 29, 2023

No description provided.

@Mednoob
Copy link
Contributor

Mednoob commented Aug 29, 2023

Looks good. One minor issue though, you need to add the language code in src/config/index.ts and .env_example. Also, add your github to README.md Translators section. You can click those links to see directly where you need to edit.

@mzrtamp mzrtamp changed the title Add Vietnamese feat(lang): Add Vietnamese Aug 29, 2023
@hmz121
Copy link
Contributor Author

hmz121 commented Aug 29, 2023

All done, thanks for reminding me

Copy link
Member

@mzrtamp mzrtamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mzrtamp mzrtamp merged commit 8d7db6b into stegripe:main Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants