Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): list-of-available-rules (closes #103) #192

Merged
merged 2 commits into from
Feb 18, 2023

Conversation

denisbalyko
Copy link
Contributor

Added flag to command statoscope validation --rules

# Please, use semantic commit message:
# type(scope): message
# or
# type: message
#
# Types are:
# - build - code build changes (webpack config, etc)
# - ci - CI changes (GitHub actions, CI scripts)
# - docs - documentation changes
# - feat - new features
# - fix - bug fixes
# - perf - performance improvements
# - refactor - code refactoring (also types changes)
# - style - code style changes (also eslint/prettier config changes)
# - test - add/fix/remove tests, or change jest configuration
# - chore - everything else
#
# The scope is a package name that changes related to
#
# For example:
# test(cli): add foo command
# or
# docs: fix root readme typos
@denisbalyko denisbalyko changed the title feat(cli): list-of-available-rules feat(cli): list-of-available-rules (closes #103) Dec 4, 2022
@denisbalyko
Copy link
Contributor Author

to #103

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2022

Codecov Report

Merging #192 (91e859b) into master (f42a3c8) will decrease coverage by 4.44%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   60.98%   56.53%   -4.45%     
==========================================
  Files         135      136       +1     
  Lines        3488     4026     +538     
  Branches      731      916     +185     
==========================================
+ Hits         2127     2276     +149     
- Misses       1354     1739     +385     
- Partials        7       11       +4     
Impacted Files Coverage Δ
packages/cli/src/commands/validate.ts 98.07% <100.00%> (+0.93%) ⬆️
packages/cli/src/commands/injectReport.ts 0.00% <0.00%> (-65.31%) ⬇️
packages/cli/src/utils.ts 90.27% <0.00%> (-9.73%) ⬇️
packages/webpack-model/src/index.ts 92.85% <0.00%> (-7.15%) ⬇️
packages/report-writer/src/index.ts 95.65% <0.00%> (-4.35%) ⬇️
...src/rules/diff-entry-download-size-limits/index.ts 87.09% <0.00%> (-2.91%) ⬇️
...extension-stats-validation-result/src/generator.ts 83.33% <0.00%> (-2.88%) ⬇️
...ages/stats-extension-package-info/src/generator.ts 91.89% <0.00%> (-2.40%) ⬇️
...ages/stats-validator-reporter-console/src/index.ts 87.30% <0.00%> (-2.36%) ⬇️
packages/webpack-model/src/normalizeCompilation.ts 96.00% <0.00%> (-1.96%) ⬇️
... and 34 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@smelukov
Copy link
Member

smelukov commented Dec 5, 2022

@denisbalyko Hi! Thanks for the PR ☺️
But #103 is about a list of available rules that plugins (used in your statoscope-config) provide.
We need to handle plugins list from a config and rules of each plugin.
You could find how stats-validator collects this info here
You could implement something like that here

@denisbalyko denisbalyko force-pushed the feat.list-of-available-rules branch from d61aef1 to 91e859b Compare December 12, 2022 18:56
@smelukov smelukov merged commit d7fda76 into statoscope:master Feb 18, 2023
@smelukov
Copy link
Member

Thanks!

@denisbalyko denisbalyko deleted the feat.list-of-available-rules branch February 19, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants