Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent usage of isMounted (react/no-is-mounted) #1569

Closed
feross opened this issue Oct 28, 2020 · 0 comments
Closed

Prevent usage of isMounted (react/no-is-mounted) #1569

feross opened this issue Oct 28, 2020 · 0 comments
Labels
accepted enhancement
Milestone
standard 16

Comments

@feross
Copy link
Member

feross commented Oct 28, 2020

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-is-mounted.md

isMounted is an anti-pattern, is not available when using ES6 classes, and it is on its way to being officially deprecated.

Rule Details

Examples of incorrect code for this rule:

var Hello = createReactClass({
  handleClick: function() {
    setTimeout(function() {
      if (this.isMounted()) {
        return;
      }
    });
  },
  render: function() {
    return <div onClick={this.handleClick.bind(this)}>Hello</div>;
  }
});

Examples of correct code for this rule:

var Hello = createReactClass({
  render: function() {
    return <div onClick={this.props.handleClick}>Hello</div>;
  }
});
@feross feross added this to the standard 16 milestone Oct 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted enhancement
Projects
The Standard Project
Archived in project
Milestone
standard 16
Development

No branches or pull requests
1 participant
@feross