feat: use store-info resource #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinWu666
force-pushed
the
store-info-resource
branch
from
a497634 to
5f89747
Compare
AustinWu666
approved these changes
Nov 4, 2024
kchung
force-pushed
the
store-info-resource
branch
from
5f89747 to
89cf20c
Compare
AustinWu666
reviewed
Nov 4, 2024
| @@ -47,7 +47,7 @@ | |||
| {% endblock %} | |||
| </head> | |||
|
|
|||
| {% set defaultFulfillment = (square.store.default_item_fulfillment|split(',')[0])|default('SHIPMENT') %} | |||
| {% set defaultFulfillment = (store_info.default_item_fulfillment|split(',')[0])|default('SHIPMENT') %} | |||
There was a problem hiding this comment.
Here where do we actually get the store-info schema reference from?
There was a problem hiding this comment.
Now that i can get it to resolve now let me test it out, I think it works because the "parent" template has access to this
There was a problem hiding this comment.
yeah, as long as the parent who is extending this file pulls it in, it should be able to access it. i had to update my PR to add store-info to all pages since all pages extend this file
kchung
force-pushed
the
store-info-resource
branch
from
89cf20c to
6b57130
Compare
AustinWu666
approved these changes
Nov 5, 2024
| @@ -47,7 +47,7 @@ | |||
| {% endblock %} | |||
| </head> | |||
|
|
|||
| {% set defaultFulfillment = (square.store.default_item_fulfillment|split(',')[0])|default('SHIPMENT') %} | |||
| {% set defaultFulfillment = (store_info.default_item_fulfillment|split(',')[0])|default('SHIPMENT') %} | |||
|
🎉 This PR is included in version 1.0.0-alpha.15 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
bashunaimiroy
added a commit
that referenced
this pull request
Nov 20, 2024
* alpha: fix: use `seller_preferred_fulfillment` for default fulfillment (#73) feat: use store-info resource (#72) fix: Item filters not working and resolve the filter name mismatch (#70) fix: fix integrity missing cross origin anonymous (#69) build(dependencies): update vulnerable packages (#68) fix: add integrity to cdn scripts and remove unused (#67) chore: add integrity to cdn scripts and remove unused (#66) ci(github-actions): use specific semantic-release version (#63)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
square.storeinfo global is deprecated and will be removed in favor thestore-inforesource. Thestore-inforesource should improve cacheabilitySee breaking changes documentation
Changes
store-inforesource