Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use system page properties #52

Merged
merged 11 commits into from
Mar 27, 2024
Merged

feat: use system page properties #52

merged 11 commits into from
Mar 27, 2024

Conversation

kchung
Copy link
Collaborator

@kchung kchung commented Feb 21, 2024

Changes

  • Transition System Pages to use Page properties

This required defining the pagination and sorting logic to the templates

@kchung kchung force-pushed the use-system-properties branch from 58dfff6 to f114774 Compare February 21, 2024 00:58
@kchung kchung requested a review from sohnj877 February 21, 2024 17:11
@kchung kchung marked this pull request as ready for review February 22, 2024 22:03
@bashunaimiroy bashunaimiroy self-requested a review February 27, 2024 16:43
@kchung kchung force-pushed the use-system-properties branch from 8634303 to 2e9d2e8 Compare February 27, 2024 17:45
site/pages/category.json Outdated Show resolved Hide resolved
theme/templates/store/category.html.twig Outdated Show resolved Hide resolved
theme/templates/store/category.html.twig Outdated Show resolved Hide resolved
@kchung kchung merged commit b72d603 into alpha Mar 27, 2024
3 checks passed
@kchung kchung deleted the use-system-properties branch March 27, 2024 19:47
Copy link

🎉 This PR is included in version 1.0.0-alpha.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

sohnj877 added a commit that referenced this pull request Mar 28, 2024
…ore-locator

* 'alpha' of https://github.com/square/brisk-theme: (52 commits)
  feat: use system page properties (#52)
  fix: rename 'option' to 'control' in section controls (#59)
  refactor: rename 'option' to 'control' in section controls (#57)
  fix: search result 500 (#54)
  fix: respond to breaking changes (#55)
  feat(async): release async template removal (#53)
  refactor: remove async templates (#50)
  ci(github-action): use latest version of checkout action (#49)
  ci(github-actions): fix commitlint help url config (#48)
  ci(github-actions): add commit linting (#47)
  docs: update theme version (#46)
  fix: banner image missing on shop all (#45)
  refactor(home): update home sections (#43)
  chore: update hooks (#42)
  docs: add contributing file (#41)
  build(github-actions): update job action versions (#40)
  build(github-actions): add lint action (#39)
  build(release): add semantic releases (#38)
  Fix link control
  Update page to use lowercase value
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants