Add container-mode to rename localhost to the container host name #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swallez
added
the
environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165
Introduces a new
--container-modeCLI flag, with the associatedCONTAINER_MODEenvironment variable.It's meant to enable some default values and behaviors that are more suited/needed when running in a container:
127.0.0.1to0.0.0.0(this was done previously automatically with thein_containercrate)localhostto the hostname of the container host (host.docker.internalfor Docker,host.containers.internalfor Podman, more can be added in the future).The
Dockerfiles have also been updated to haveENV CONTAINER_MODE=trueAlso updates the Dockerfile's dependency caching so that it actually works 😅