refactor(astutils): remove redundant nil check in Walk (#2660)

Juneezee · web-flow · commit ecf4980574d0 · 2023-08-28T12:39:48.000-07:00
From the Go docs: "For a nil slice, the number of iterations is 0." [1] Therefore, an additional nil check for before the loop is unnecessary. [1]: https://go.dev/ref/spec#For_range Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
diff --git a/internal/sql/astutils/walk.go b/internal/sql/astutils/walk.go
@@ -2158,10 +2158,8 @@ func Walk(f Visitor, node ast.Node) {
 		}
 
 	case *ast.In:
-		if n.List != nil {
-			for _, l := range n.List {
-				Walk(f, l)
-			}
+		for _, l := range n.List {
+			Walk(f, l)
 		}
 		if n.Sel != nil {
 			Walk(f, n.Sel)

Original file line number	Diff line number	Diff line change
`@@ -2158,10 +2158,8 @@ func Walk(f Visitor, node ast.Node) {`
`2158`	`2158`	`}`
`2159`	`2159`
`2160`	`2160`	`case *ast.In:`
`2161`		`- if n.List != nil {`
`2162`		`- for _, l := range n.List {`
`2163`		`- Walk(f, l)`
`2164`		`- }`
	`2161`	`+ for _, l := range n.List {`
	`2162`	`+ Walk(f, l)`
`2165`	`2163`	`}`
`2166`	`2164`	`if n.Sel != nil {`
`2167`	`2165`	`Walk(f, n.Sel)`