Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wrapper] add more SVGIcons #2648

Open
ohitstom opened this issue Nov 9, 2023 · 3 comments
Open

[wrapper] add more SVGIcons #2648

ohitstom opened this issue Nov 9, 2023 · 3 comments
Labels
🔵 extension wrapper Issue or Pull Request about wrapper functionality

Comments

@ohitstom
Copy link
Contributor

ohitstom commented Nov 9, 2023 •
edited
Loading

📝 Provide a description of the new feature

As of Spotify for Windows (64 bit) 1.2.24.756.g7a7fc7f0 there are many new icons thanks to the right click context menu, these need to be added or updated aswell as extensions such as trashbin.js having its trashbin icon updated to match spotify.

➕ Additional Information

image
image
@ohitstom ohitstom mentioned this issue Nov 14, 2023
Closed
@duffey
Copy link
Contributor

duffey commented Dec 4, 2023

Need that trash can! :)

@ohitstom
Copy link
Contributor Author

ohitstom commented Dec 5, 2023

Need that trash can! :)

its a pretty sweet icon, i was going to open a PR but thought it best to wait until i get time to do #2654 first, but its a very manual labour heavy PR.....

If you need the icon personally or want to make a pr though i have its value here:
https://github.com/ohitstom/spicetify-extensions/blob/9b5db49faa4d07a4b7e35e8b6e450b347813b3e3/quickQueue/quickQueue.js#L68

@ok-coder1
Copy link

Somebody make a PR and add the icons, please!

@rxri rxri changed the title Many new icons to add to SVGIcons [wrapper] add more SVGIcons Feb 28, 2024
@rxri rxri added the wrapper Issue or Pull Request about wrapper functionality label Feb 28, 2024
@MrBiscuit921 MrBiscuit921 mentioned this issue Oct 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔵 extension wrapper Issue or Pull Request about wrapper functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(wrapper): add unmapped svgicons to "misc" key
4 participants
@duffey @rxri @ohitstom @ok-coder1