change: Do not warn in canHandle.

CommunitySolidServer · Nov 29, 2020 · baf6888 · baf6888
1 parent 10946ff
commit baf6888
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 7 deletions.
diff --git a/src/ldp/http/BasicResponseWriter.ts b/src/ldp/http/BasicResponseWriter.ts
@@ -21,7 +21,6 @@ export class BasicResponseWriter extends ResponseWriter {
 
   public async canHandle(input: { response: HttpResponse; result: ResponseDescription | Error }): Promise<void> {
     if (input.result instanceof Error || input.result.metadata?.contentType === INTERNAL_QUADS) {
-      this.logger.warn('This writer only supports binary ResponseDescriptions');
       throw new NotImplementedHttpError('Only successful binary responses are supported');
     }
   }

diff --git a/src/ldp/http/ErrorResponseWriter.ts b/src/ldp/http/ErrorResponseWriter.ts
@@ -13,7 +13,6 @@ export class ErrorResponseWriter extends ResponseWriter {
 
   public async canHandle(input: { response: HttpResponse; result: ResponseDescription | Error }): Promise<void> {
     if (!(input.result instanceof Error)) {
-      this.logger.warn('This writer can only write errors');
       throw new NotImplementedHttpError('Only errors are supported');
     }
   }

diff --git a/src/ldp/http/SparqlUpdateBodyParser.ts b/src/ldp/http/SparqlUpdateBodyParser.ts
@@ -20,7 +20,6 @@ export class SparqlUpdateBodyParser extends BodyParser {
   public async canHandle({ request }: BodyParserArgs): Promise<void> {
     const contentType = request.headers['content-type'];
     if (contentType !== APPLICATION_SPARQL_UPDATE) {
-      this.logger.debug(`Unsupported content type: ${contentType}`);
       throw new UnsupportedMediaTypeHttpError('This parser only supports SPARQL UPDATE data.');
     }
   }

diff --git a/src/ldp/permissions/MethodPermissionsExtractor.ts b/src/ldp/permissions/MethodPermissionsExtractor.ts
@@ -1,4 +1,3 @@
-import { getLoggerFor } from '../../logging/LogUtil';
 import { NotImplementedHttpError } from '../../util/errors/NotImplementedHttpError';
 import type { Operation } from '../operations/Operation';
 import type { PermissionSet } from './PermissionSet';
@@ -13,11 +12,8 @@ const SUPPORTED_METHODS = new Set([ ...READ_METHODS, ...WRITE_METHODS ]);
  * Specifically: GET, HEAD, POST, PUT and DELETE.
  */
 export class MethodPermissionsExtractor extends PermissionsExtractor {
-  protected readonly logger = getLoggerFor(this);
-
   public async canHandle({ method }: Operation): Promise<void> {
     if (!SUPPORTED_METHODS.has(method)) {
-      this.logger.warn(`Unrecognized method ${method}`);
       throw new NotImplementedHttpError(`Cannot determine permissions of ${method}`);
     }
   }