Replies: 10 comments 10 replies
-
|
We've been using Catch2 for years on various projects, including lightgrep. I'd happily set it up for the tests in #1057 after that PR is merged. |
Beta Was this translation helpful? Give feedback.
-
|
How would you set it up?
…On Thu, Sep 5, 2024 at 12:11 PM Joel Uckelman ***@***.***> wrote:
We've been using Catch2 for years on various projects, including
lightgrep. I'd happily set it up for the tests in #1057
<#1057> after that PR is
merged.
—
Reply to this email directly, view it on GitHub
<#2950 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMFHLHB2UTBN6YWNYINUGLZVB7DBAVCNFSM6AAAAABNWMRUYSVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTANJVHE3TMNQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
Apparently it is set up to use cppunit. However, it wasn't installed on my system. How does this system declare its requirements and prepare VMs? Should we create scripts to do that? |
Beta Was this translation helpful? Give feedback.
-
|
Why do we want to stop using it immediately? Most of the dev crew at SKL is using Java, so I figured that they picked cppunit back in 2010 to make everybody feel happy. I have it working on my mac right now. I'm trying to make as few changes as possible in the code base at the moment. |
Beta Was this translation helpful? Give feedback.
-
|
True, but I have it working. |
Beta Was this translation helpful? Give feedback.
-
|
You convinced me. I’ll move over in a few days.
…On Fri, Sep 6, 2024 at 5:33 AM Joel Uckelman ***@***.***> wrote:
Given that we're starting from close to zero with unit tests, we should
chose the best test framework we can.
I rarely encounter projects using cppunit these days. It's unpleasant to
work with. I'm not enthusiastic about writing tests with it and I expect
other people who might contribute tests would feel the same way.
Catch2 is pleasant to use. We've both had good experiences with it. I'm
volunteering to set it up. Catch2 has support for test order randomization,
which helps flush out otherwise hard to find bugs; test sharding, so we can
easily parallelize tests; and benchmarking, which could help us make
Sleuthkit faster. I've used all these features and would miss them in
cppunit.
Writing new tests with cppunit when we aim eventually to convert to Catch2
is wasting all the time we will spend converting those tests. We could
write them in the better framework from the start and spend less time doing
it.
—
Reply to this email directly, view it on GitHub
<#2950 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMFHLBEVYUDPQVMIVF5CUDZVGOKVAVCNFSM6AAAAABNWMRUYSVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTANJWHA4DMMI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
I've begun in PR #2956. |
Beta Was this translation helpful? Give feedback.
-
|
@uckelman-sf - Catch has undergone a significant change between v2 and v3. v2 is a single header to include; v3 now is a full library, with lots of headers. It is on the devel branch. https://github.com/catchorg/Catch2/ I'm hesitant to go with catch v3 because it is still devel, but migrating from v2 to v3 is not trivial. What is your recommendation? |
Beta Was this translation helpful? Give feedback.
-
|
Homebrew can install catch
https://formulae.brew.sh/formula/catch2
Looks like their are similar packages for Ubuntu
…On Fri, Sep 6, 2024 at 10:39 AM Joel Uckelman ***@***.***> wrote:
Internally, our overall CI framework builds Catch2. For CI here, I'm not
sure yet what will be simplest. I'll look into options for that next. (Not
until mid-week, though. I'm away for the next few days.)
—
Reply to this email directly, view it on GitHub
<#2950 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMFHLBWWCZGUTEJHDM7QE3ZVHSEHAVCNFSM6AAAAABNWMRUYSVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTANJXGIYDGNA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
Looks like we've done this. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
We had really good luck on the bulk_extractor project using catch.
https://github.com/catchorg/Catch2/blob/master/docs/tutorial.md
My intent is to create a similar test framework on TSK. I'm looking for comments and suggestions.
Beta Was this translation helpful? Give feedback.
All reactions