Remove sort tag index #2032
Merged
Remove sort tag index #2032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es it. Removing this caused some unit tests to fail, so I added initialization for QuerySummary in unit tests, and also added checks for some functions to return nil if something hadn't been initialized.
…e completion calculation of if the sortIndexEnabled was false, previously.
AndrewHess
reviewed
Jan 7, 2025
…mpletion % needs to be accurately tracked later on.
AndrewHess
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summarize the change.
Fixes # (link all the GitHub issues this addresses)
Testing
Describe how you tested this code. How can the reviewers reproduce your tests?
Checklist:
Before marking your pull request as ready for review, complete the following.
goimports -w ..