Fix content hash warning in production (#320)

ahangarha · web-flow · commit 6446127827a2 · 2023-06-27T21:09:07.000+05:00
* Reverse the condition for the warning message
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,9 @@ Changes since last non-beta release.
 
 _Please add entries here for your pull requests that are not yet released._
 
+### Fixed
+- Fixed the condition for showing warning for setting `useContentHash` to `false` in the production environment. [PR 320](https://github.com/shakacode/shakapacker/pull/320) by [ahangarha](https://github.com/ahangarha).
+
 ### Breaking changes
 - Removes defaults passed to `@babel/preset-typescript`. [PR 273](https://github.com/shakacode/shakapacker/pull/273) by [tomdracz](https://github.com/tomdracz).
 
diff --git a/package/environments/__tests__/production.js b/package/environments/__tests__/production.js
@@ -23,6 +23,19 @@ describe('Production specific config', () => {
         'js/[name]-[contenthash].chunk.js'
       )
     })
+
+    test("doesn't shows any warning message", () => {
+      const consoleWarnSpy = jest.spyOn(console, 'warn');
+      const config = require("../../config");
+      config.useContentHash = true
+      const environmnetConfig = require('../production')
+
+      expect(consoleWarnSpy).not.toHaveBeenCalledWith(
+        expect.stringMatching(/Setting 'useContentHash' to 'false' in the production environment/)
+      )
+
+      consoleWarnSpy.mockRestore()
+    })
   })
 
   describe('with config.useContentHash = false', () => {
@@ -36,6 +49,19 @@ describe('Production specific config', () => {
         'js/[name]-[contenthash].chunk.js'
       )
     })
+
+    test('shows a warning message', () => {
+      const consoleWarnSpy = jest.spyOn(console, 'warn');
+      const config = require("../../config");
+      config.useContentHash = false
+      const environmnetConfig = require('../production')
+
+      expect(consoleWarnSpy).toHaveBeenCalledWith(
+        expect.stringMatching(/Setting 'useContentHash' to 'false' in the production environment/)
+      )
+
+      consoleWarnSpy.mockRestore()
+    })
   })
 
   describe('with unset config.useContentHash', () => {
@@ -49,5 +75,18 @@ describe('Production specific config', () => {
         'js/[name]-[contenthash].chunk.js'
       )
     })
+
+    test("doesn't shows any warning message", () => {
+      const consoleWarnSpy = jest.spyOn(console, 'warn');
+      const config = require("../../config");
+      delete config.useContentHash
+      const environmnetConfig = require('../production')
+
+      expect(consoleWarnSpy).not.toHaveBeenCalledWith(
+        expect.stringMatching(/Setting 'useContentHash' to 'false' in the production environment/)
+      )
+
+      consoleWarnSpy.mockRestore()
+    })
   })
 })
diff --git a/package/environments/production.js b/package/environments/production.js
@@ -77,7 +77,7 @@ const productionConfig = {
   }
 }
 
-if (config.useContentHash === true) {
+if (config.useContentHash === false) {
   // eslint-disable-next-line no-console
   console.warn(`&#9888;&#65039; WARNING
 Setting 'useContentHash' to 'false' in the production environment (specified by NODE_ENV environment variable) is not allowed!

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ const productionConfig = {`
`77`	`77`	`}`
`78`	`78`	`}`
`79`	`79`
`80`		`-if (config.useContentHash === true) {`
	`80`	`+if (config.useContentHash === false) {`
`81`	`81`	`// eslint-disable-next-line no-console`
`82`	`82`	console.warn(`⚠️ WARNING
`83`	`83`	`Setting 'useContentHash' to 'false' in the production environment (specified by NODE_ENV environment variable) is not allowed!`