Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to java17 as default #186

Open
serpro69 opened this issue Mar 19, 2023 · 1 comment
Open

Move to java17 as default #186

serpro69 opened this issue Mar 19, 2023 · 1 comment
Labels
core 🧬 Issue related to :core module enhancement 🚀 New feature or request needs info ❓ Further information is requested
Milestone
2.0.0

Comments

@serpro69
Copy link
Owner

serpro69 commented Mar 19, 2023 •
edited
Loading

This is to gather details on moving to java17 as minimum requirement and start with the implementation.
The plan is to release this in 2.0.0.

Acceptance criteria:

  • java17 is the minimal java version for kotlin-faker:2.0.0
  • java8 is supported (via own artifact? kotlin-faker-jdk8?)
    • (optionally java11 should also be supported in a similar fashion?)
  • kotlin 2.0.0 (if released by then) is the minimal kotlin version for kotlin-faker:2.0.0
    • backwards compatibility with 1.[789].x is unclear at this point

Some useful documentation from gradle:
@serpro69 serpro69 added enhancement 🚀 New feature or request core 🧬 Issue related to :core module labels Mar 19, 2023
@serpro69 serpro69 added this to the 2.0.0 milestone Mar 19, 2023
@serpro69 serpro69 changed the title Support for java17 Move to java17 as default Mar 26, 2023
@serpro69
Copy link
Owner Author

serpro69 commented Mar 30, 2024 •
edited
Loading

OK, I'm not really sure this makes sense for a kotlin-based library. What benefits do we get from defaulting to java17 when the primary language is kotlin? I can't see any, at least until kotlin starts declaring "minimal supported java version".
At the same time, implementing this issue would require introduction of another artifact to make the lib compatible with java8.
Need to think more on it before breaking java8 compatibility.

@serpro69 serpro69 added the needs info ❓ Further information is requested label Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core 🧬 Issue related to :core module enhancement 🚀 New feature or request needs info ❓ Further information is requested
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@serpro69