Support --lang parameter in serge pull-ts and serge push-ts

Igor Afanasyev · Igor Afanasyev · commit 9dbff387ea89 · 2018-02-01T20:20:39.000-08:00
diff --git a/CHANGES b/CHANGES
@@ -2,6 +2,12 @@ Revision history
 
 1.4     Pending release
 
+        - Support `--lang` parameter in `serge pull-ts` and `serge push-ts`
+          (gives an ability to specify one or more languages which should be
+          synchronized with the translation service). Previously this parameter
+          worked only for `serge sync` and `serge localize` and only affected
+          the localization step.
+
 1.3     February 1, 2018
 
         - Fix bug when extra item comment would be appended only if the
diff --git a/doc/html/serge-pull-ts.html b/doc/html/serge-pull-ts.html
@@ -41,6 +41,12 @@ <h1 id="OPTIONS">OPTIONS</h1>
 
 <p>Instruct the remote party to skip any optimizations and force update all translation files.</p>
 
+</dd>
+<dt><b>--lang=xx[,yy][,zz]</b>, <b>--language=xx[,yy][,zz]</b> <b>--languages=xx[,yy][,zz]</b></dt>
+<dd>
+
+<p>See <code><a href="serge-localize.html">serge localize --lang</a></code>. Will also completely skip processing configs where no target languages are found.</p>
+
 </dd>
 <dt><b>--echo-commands</b></dt>
 <dd>
diff --git a/doc/html/serge-push-ts.html b/doc/html/serge-push-ts.html
@@ -41,6 +41,12 @@ <h1 id="OPTIONS">OPTIONS</h1>
 
 <p>Instruct the remote party to skip any optimizations and force update data from all translation files.</p>
 
+</dd>
+<dt><b>--lang=xx[,yy][,zz]</b>, <b>--language=xx[,yy][,zz]</b> <b>--languages=xx[,yy][,zz]</b></dt>
+<dd>
+
+<p>See <code><a href="serge-localize.html">serge localize --lang</a></code>. Will also completely skip processing configs where no target languages are found.</p>
+
 </dd>
 <dt><b>--echo-commands</b></dt>
 <dd>
diff --git a/doc/pod/serge-pull-ts.pod b/doc/pod/serge-pull-ts.pod
@@ -24,6 +24,11 @@ from remote translation server into the local directory.
 
 Instruct the remote party to skip any optimizations and force update all translation files.
 
+=item B<--lang=xx[,yy][,zz]>, B<--language=xx[,yy][,zz]> B<--languages=xx[,yy][,zz]>
+
+See C<< L<serge localize --lang|serge-localize> >>.
+Will also completely skip processing configs where no target languages are found.
+
 =item B<--echo-commands>
 
 Echo system commands about to be executed (useful for debugging)
diff --git a/doc/pod/serge-push-ts.pod b/doc/pod/serge-push-ts.pod
@@ -25,6 +25,11 @@ to remote translation server.
 Instruct the remote party to skip any optimizations
 and force update data from all translation files.
 
+=item B<--lang=xx[,yy][,zz]>, B<--language=xx[,yy][,zz]> B<--languages=xx[,yy][,zz]>
+
+See C<< L<serge localize --lang|serge-localize> >>.
+Will also completely skip processing configs where no target languages are found.
+
 =item B<--echo-commands>
 
 Echo system commands about to be executed (useful for debugging)
diff --git a/doc/pod/serge-sync.pod b/doc/pod/serge-sync.pod
@@ -36,13 +36,13 @@ Has the same effect as C<< L<serge localize --output-only-mode|serge-localize> >
 
 =item B<--lang=xx[,yy][,zz]>, B<--language=xx[,yy][,zz]> B<--languages=xx[,yy][,zz]>
 
-See C<< L<serge localize --lang|serge-localize> >>. Will also completely skip processing configs where
-no target languages are found.
+See C<< L<serge localize --lang|serge-localize> >>.
+Will also completely skip processing configs where no target languages are found.
 
 =item B<--job=xx[,yy][,zz]>, B<--jobs=xx[,yy][,zz]>
 
-See C<< L<serge localize --job|serge-localize> >>. Will also completely skip processing configs where
-no target jobs are found.
+See C<< L<serge localize --job|serge-localize> >>.
+Will also completely skip processing configs where no target jobs are found.
 
 =item B<--message="commit message">
 
diff --git a/lib/Serge/Command/sync.pm b/lib/Serge/Command/sync.pm
@@ -37,6 +37,7 @@ sub init {
     if ($command =~ m/^(pull-ts|localize|push-ts|sync)$/) {
         GetOptions(
             "force"         => \$self->{force},
+            "lang|language|languages=s" => \$self->{languages},
         ) or die $error_msg;
     }
 
@@ -55,7 +56,6 @@ sub init {
 
     if ($command =~ m/^(localize|sync)$/) {
         GetOptions(
-            "lang|language|languages=s" => \$self->{languages},
             "job|jobs=s"                => \$self->{jobs},
             "rebuild-ts-files"           => \$self->{rebuild_ts_files},
             "output-only-mode"          => \$self->{output_only_mode},
@@ -89,6 +89,7 @@ sub run {
     my %limit_languages;
     if ($self->{languages}) {
         my @l = split(/,/, $self->{languages});
+        $sync->{languages} = \@l;
         $engine->{limit_destination_languages} = \@l;
         @limit_languages{@l} = @l;
     }
diff --git a/lib/Serge/Sync.pm b/lib/Serge/Sync.pm
@@ -115,7 +115,7 @@ sub do_sync {
     } else {
         print "\nPulling translation files from external translation service...\n\n";
         my $start = [gettimeofday];
-        $self->{ts}->pull_ts; # update all languages
+        $self->{ts}->pull_ts($self->{languages}); # update all languages
         print "'pull-ts' step took ", tv_interval($start), " seconds\n";
     }
 
@@ -142,7 +142,7 @@ sub do_sync {
     } else {
         print "\nPushing translation files to external translation service...\n\n";
         my $start = [gettimeofday];
-        $self->{ts}->push_ts; # update all languages
+        $self->{ts}->push_ts($self->{languages}); # update all languages
         print "'push-ts' step took ", tv_interval($start), " seconds\n";
     }
 
