Closed
Description
Describe the bug
Comparing certain decimals with the significant_digits argument leads to an invalidDecimal exception from being raised within deep diff
To Reproduce
from decimal import Decimal
from deepdiff import DeepDiff
diff = DeepDiff([Decimal("999.99999999")], [Decimal("999.9999999999")], significant_digits=6)
# exception will raise
Expected behavior
There should be no exception and no values_changed
OS, DeepDiff version and Python version (please complete the following information):
- OS: mac os
- Version: 13.6
- Python Version: 3.11.4
- DeepDiff Version: 6.6.0
Additional context
Stack trace:
Traceback (most recent call last):
File "/Users/stefan/code/coin-tracker/coin-tracker-server/testdeepdiff.py", line 6, in <module>
diff = DeepDiff([Decimal("999.99999999")], [Decimal("999.9999999999")], significant_digits=6)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/stefan/code/coin-tracker/coin-tracker-server/.venv/lib/python3.11/site-packages/deepdiff/diff.py", line 311, in __init__
self._diff(root, parents_ids=frozenset({id(t1)}), _original_type=_original_type)
File "/Users/stefan/code/coin-tracker/coin-tracker-server/.venv/lib/python3.11/site-packages/deepdiff/diff.py", line 1569, in _diff
self._diff_iterable(level, parents_ids, _original_type=_original_type, local_tree=local_tree)
File "/Users/stefan/code/coin-tracker/coin-tracker-server/.venv/lib/python3.11/site-packages/deepdiff/diff.py", line 655, in _diff_iterable
self._diff_iterable_in_order(level, parents_ids, _original_type=_original_type, local_tree=local_tree)
File "/Users/stefan/code/coin-tracker/coin-tracker-server/.venv/lib/python3.11/site-packages/deepdiff/diff.py", line 761, in _diff_iterable_in_order
self._diff_ordered_iterable_by_difflib(
File "/Users/stefan/code/coin-tracker/coin-tracker-server/.venv/lib/python3.11/site-packages/deepdiff/diff.py", line 902, in _diff_ordered_iterable_by_difflib
self._diff_by_forming_pairs_and_comparing_one_by_one(
File "/Users/stefan/code/coin-tracker/coin-tracker-server/.venv/lib/python3.11/site-packages/deepdiff/diff.py", line 887, in _diff_by_forming_pairs_and_comparing_one_by_one
self._diff(next_level, parents_ids_added, local_tree=local_tree)
File "/Users/stefan/code/coin-tracker/coin-tracker-server/.venv/lib/python3.11/site-packages/deepdiff/diff.py", line 1551, in _diff
self._diff_numbers(level, local_tree=local_tree, report_type_change=report_type_change)
File "/Users/stefan/code/coin-tracker/coin-tracker-server/.venv/lib/python3.11/site-packages/deepdiff/diff.py", line 1360, in _diff_numbers
t1_s = self.number_to_string(level.t1,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/stefan/code/coin-tracker/coin-tracker-server/.venv/lib/python3.11/site-packages/deepdiff/helper.py", line 397, in number_to_string
number = number.quantize(Decimal('0.' + '0' * significant_digits))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
decimal.InvalidOperation: [<class 'decimal.InvalidOperation'>]
I dont quite understand why your code doesnt work. When i try to reproduce outside of your library, i dont have issues:
from decimal import Decimal
n = Decimal('999.999999999')
n.quantize(Decimal('0.' + '0' * 6))
# => Decimal('1000.000000')
Metadata
Metadata
Assignees
Labels
No labels