sel4-deps: cypthon >=3 breaks pyyaml < 6 at build #1295
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require cython < 3, because >=3 breaks the install for pyyaml < 5.4 at build/install time for more recent python version. pyyaml 5.4 also breaks, but is not fixed by downgrading cython, so we also require pyyaml < 5.4. See also <yaml/pyyaml#601> Signed-off-by: Gerwin Klein <[email protected]>
|
The better fix would be to upgrade |
How do you want to proceed? Still merge this first? |
Indanz
approved these changes
Aug 5, 2024
|
We should probably hold off on this one since we decided to bump cmake-format and with that we won't need to restrict versions quiet so much. |
|
Putting this on draft for now to keep it here until cmake-format is bumped. This PR should be closed once that is done and is working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require cython < 3, because >=3 breaks the install for pyyaml at build/install time for more recent python versions. The cython < 3 fix only works on pyyaml < 5.4, so we add < 5.4 there instead of < 6 (which was already required by cmake-format=0.4.5).
See also yaml/pyyaml#601
sel4-deps 0.6.0 isn't published yet (yay for pypitest..), so no version bump.
This whole thing is getting somewhat frustrating, but this combination should at least work in a fresh install.