Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

BayesSearchCV: default value mentioned for cv is wrong in the doc #1157

Open
robertlbyrne opened this issue Mar 16, 2023 · 1 comment
Open

Comments

@robertlbyrne
Copy link

Hi,

Is there a bug in the Docs for BayesSearchCV where it says that the default value for cv is 3 but I see it using 5 as the default when I run it with no explicit value for cv?

https://scikit-optimize.github.io/dev/modules/generated/skopt.BayesSearchCV.html#skopt.BayesSearchCV

I had a quick look in the code as below, the default in the code that is used seems to be 5.

cheers,
Rob.

Versions:

import sklearn
import skopt
print(sklearn.version)
print(skopt.version)

1.0.2
0.9.0


Docs from: https://scikit-optimize.github.io/dev/modules/generated/skopt.BayesSearchCV.html#skopt.BayesSearchCV

cv: int, cross-validation generator or an iterable, optional
Determines the cross-validation splitting strategy. Possible inputs for cv are:

None, to use the default 3-fold cross validation,

scikit-learn/sklearn/model_selection/_split.py

Line 2404 in f2f3b3c

def check_cv(cv=5, y=None, *, classifier=False): 
def check_cv(cv=5, y=None, *, classifier=False):
"""Input checker utility for building a cross-validator.
@yeongkwoncho
Copy link

Hi, I also found myself that it is actually 5 and it's different from the description.
Someone who manages skoptimize should fix this ASAP.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants