CI Fix rendered doc affected paths for towncrier fragments #30361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like this is working, see this PR affected paths
I am going to revert the changes that I made for testing. |
This reverts commit 6ed87ab.
jeremiedbb
approved these changes
Nov 28, 2024
Yep, I thought about what we said some time ago, next time we will put the logic in a Python file and I was like, hmmm yeah next time maybe I'll do it 😅
Agreed it's a bit weird, at the same time what I care about in a PR is to check the HTML rendering is fine. I don't know if other projects (astropy, numpy, etc ...) have a better setup. |
|
All right let's merge to not delay things further |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Dec 4, 2024
jeremiedbb
pushed a commit
that referenced
this pull request
Dec 6, 2024
virchan
pushed a commit
to virchan/scikit-learn
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen in #30360, the generated link is wrong and does not exist, it should point to the changelog file.
