TST check inheritance order in common tests #30234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam2392
approved these changes
Nov 7, 2024
Comment on lines
+1790
to
+1791
| "This means, for instance, `BaseEstimator` should be on the right side of most " | ||
| "other mixins. You need to change the order so that:\n" |
There was a problem hiding this comment.
Is there ever a case BaseEstimator would come on the left side?
There was a problem hiding this comment.
Not that I know of, but I also don't know everything, that's why my sentence here is not too definite 😅
thomasjpfan
approved these changes
Nov 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30228
This adds a test to our API checks, to test whether the inheritance order is correct.
We can add / change the defined DAG in the future / in this PR.
cc @adam2392 @thomasjpfan @glemaitre