DOC: first draft on the comms #21287

GaelVaroquaux · 2021-10-08T16:05:57Z

The goal of this PR is to make official the existance of the comms team.

GaelVaroquaux · 2021-10-08T16:09:34Z

This PR is open for comments on the structure of the team. For instance, I chose not to use github teams for now, but this is questionable.

I think that I'd like the description of the duties to be light, in the spirit of empowering and trusting people. But maybe I'm wrong and unwritten rules are bad for dynamics.

reshamas · 2021-10-08T16:26:07Z

I think it will be good to have a GitHub teams for comms. The purpose is that when a milestone PR has been merged, they can be notified, and that can be shared on social media.

I think this PR does what we need which is acknowledge the creation of the team, adding team members to the scikit-learn contributors page, and empowering them to use the social media accounts.

reshamas · 2021-10-11T19:29:08Z

cc: @laurburke

adrinjalali · 2021-10-11T21:29:55Z

doc/governance.rst

+For this, they can operate the scikit-learn accounts on various social
+networks and produce materials.
+
+Every new communicator will be announced in the mailing list.


We do need a way to add and remove members from the list though, which should be a part of this part of the governance.

Since things going on social media are done directly by the members and don't do through the review process/access control, my proposal would be my our usual vote for core devs, with the extension that members of the comms team can nominate others members.

For removing members for the Comms Team, can it be that if a member has been inactive for 3 or 6 months, or some specified time period, they will be removed?

For members who are brand new, can we do:

first 3 months as a "Temporary Triage Team Member"

after 3 months, they can become a "Regular Triage Team Member"

I think we can be better at giving expectations (such as this time period) for new team members. For us, this might also mean being better at mentoring them during this period -- at least I can improve.

jjerphan

Apart from the ongoing thread and my comment, LGTM!

I think we should move forward with setting up this new team.

jjerphan · 2021-11-11T07:56:55Z

doc/governance.rst

+Communicators are welcome to participate in `monthly core developer meetings
+<https://github.com/scikit-learn/administrative/tree/master/meeting_notes>`_.


Naive question: as the overall team grows, this meeting won't just be for core-developer but also a triagers' and communicators'.

Hence, should we:

rename it to include everyone

and/or have more lighter and scoped meetings (e.g. one dedicated to technical decisions and SLEP, another for triaging, another for communication, etc.)

?

@jjerphan I think this is a great suggestion. Discussion for wider topics will help move some of these initiatives forward in scikit-learn. Currently, we spend a good 30-45 minutes discussing the first PR on the list and it doesn't leave much time to discuss other items on the agenda.

I think we can start off with having two meetings:

Technical decisions and SLEP

Community & communication

jjerphan · 2021-11-11T08:01:52Z

doc/governance.rst

+For this, they can operate the scikit-learn accounts on various social
+networks and produce materials.
+
+Every new communicator will be announced in the mailing list.


I think we can be better at giving expectations (such as this time period) for new team members. For us, this might also mean being better at mentoring them during this period -- at least I can improve.

GaelVaroquaux · 2021-11-11T10:39:31Z

I think we should move forward with setting up this new team.

On this PR, I still need to setup the authentication infrastruture (the github team, and the script that pulls from it to list people). But I cannot find time to do it. I could use someone picking up this PR and finishing it.

jjerphan · 2021-11-12T07:46:48Z

I've tried setting up the team but deleted it directly after its creation: it seems that only people having admin rights (owners?) can setup a team properly i.e. setup with admin rights and access its information using GitHub API, as done in the script @GaelVaroquaux mentioned:

scikit-learn/build_tools/generate_authors_table.py

Lines 41 to 49 in bbb81e9

    
           def get_contributors(): 
        
               """Get the list of contributor profiles. Require admin rights.""" 
        
               # get core devs and triage team 
        
               core_devs = [] 
        
               triage_team = [] 
        
               for team_id, lst in zip((11523, 3593183), (core_devs, triage_team)): 
        
                   for page in [1, 2]:  # 30 per page 
        
                       reply = get(f"https://api.github.com/teams/{team_id}/members?page={page}") 
        
                       lst.extend(reply.json())

Do you have some time to do it, @adrinjalali?

adrinjalali · 2021-11-12T14:58:57Z

I created a team: https://github.com/orgs/scikit-learn/teams/communication-team/members

You should be able to read it's info and members @jjerphan

jjerphan · 2021-11-12T17:56:09Z

We just need the ID of the communication team to add it to this line:

scikit-learn/build_tools/generate_authors_table.py

Line 46 in bbb81e9

for team_id, lst in zip((11523, 3593183), (core_devs, triage_team)):

but I can't get this piece of information due to insufficient privileges. For instance:

$ curl -i -u jjerphan:<token> https://api.github.com/orgs/scikit-learn/teams
HTTP/2 403 
# ...
{
  "message": "Must have admin rights to Repository.",
  "documentation_url": "https://docs.github.com/rest/reference/teams#list-teams"
}

rth · 2021-11-12T18:33:46Z

@jjerphan The communication team ID is: 5368696.

Co-authored-By: Adrin Jalali <[email protected]> Co-authored-by: Roman Yurchak <[email protected]>

jjerphan · 2021-11-15T17:35:48Z

Apart from @laurburke, are there other people to include in the communication team?

Edit: I can't add people to the team, nor can I access its info via the GitHub API.

reshamas · 2021-11-15T23:31:46Z

@jjerphan

Apart from @laurburke, are there other people to include in the communication team?

We can add: @ogrisel

I don't know if @adrinjalali and @GaelVaroquaux wants to receive the extra notifications. Can ask them.

adrinjalali · 2021-11-16T10:45:28Z

Thanks for asking @reshamas , but I don't think I need to get the comms notifications.

GaelVaroquaux · 2021-11-16T10:49:25Z

I don't know if @adrinjalali and @GaelVaroquaux wants to receive the extra notifications.

I don't need to be in the comms team, but if it helps for my input on specific points, I'm happy to be in there. Thanks!!

rth · 2021-11-16T20:01:24Z

@jjerphan I just sent an invite to @laurburke.

Maybe we should merge as is, then fix other things as needed? The team has been officially created a while ago and it's still not reflected in the documentation which is not ideal.

jjerphan · 2021-11-17T07:28:49Z

@jjerphan I just sent an invite to @laurburke.

Maybe we should merge as is, then fix other things as needed? The team has been officially created a while ago and it's still not reflected in the documentation which is not ideal.

I do agree: in this regards, I already have approved this PR and I am waiting for someone else to.

adrinjalali · 2021-11-17T10:57:25Z

Happy to check and merge if the CI is fixed, a bit occupied to check the issue myself right now @jjerphan

jjerphan · 2021-11-18T09:08:29Z

@adrinjalali: I believe you can have a look at this PR if interested -- the problems on the CI have been identified and are unrelated to the changes made in this PR.

adrinjalali · 2021-11-18T12:05:09Z

Doc build is not fixed, I just wanted to have a look at how it's rendered before merging. Could you please merge with main?

jjerphan · 2021-11-18T14:13:35Z

As Circle CI has not cached it.

adrinjalali

Let's merge and improve on this one if necessary then.

jjerphan · 2021-11-18T14:44:56Z

Welcome on board, @laurburke! 🙌

GaelVaroquaux · 2021-11-18T14:53:23Z

Welcome on board, @laurburke! 🙌

Yes!! Welcome on board, and thanks to the team for finishing my PR!

* DOC: first draft on the comms * Extend table generation script to add the Communication team Co-authored-By: Adrin Jalali <[email protected]> Co-authored-by: Roman Yurchak <[email protected]> * DOC Update communication team details * Add Lauren Burke to the communication team Co-authored-by: Julien Jerphanion <[email protected]> Co-authored-by: Adrin Jalali <[email protected]> Co-authored-by: Roman Yurchak <[email protected]>

DOC: first draft on the comms

8dcc9bc

github-actions bot added the Documentation label Oct 8, 2021

GaelVaroquaux requested a review from reshamas October 8, 2021 16:09

reshamas approved these changes Oct 8, 2021

View reviewed changes

adrinjalali reviewed Oct 11, 2021

View reviewed changes

jjerphan approved these changes Nov 11, 2021

View reviewed changes

jjerphan and others added 2 commits November 12, 2021 19:48

Extend table generation script to add the Communication team

e1a0a68

Co-authored-By: Adrin Jalali <[email protected]> Co-authored-by: Roman Yurchak <[email protected]>

DOC Update communication team details

144c330

Add Lauren Burke to the communication team

a11a36a

Merge branch 'main' into communication_team

c6c75cc

adrinjalali approved these changes Nov 18, 2021

View reviewed changes

adrinjalali merged commit 26ed0a2 into scikit-learn:main Nov 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DOC: first draft on the comms #21287

DOC: first draft on the comms #21287

GaelVaroquaux commented Oct 8, 2021

GaelVaroquaux commented Oct 8, 2021

reshamas commented Oct 8, 2021

reshamas commented Oct 11, 2021

adrinjalali Oct 11, 2021

reshamas Oct 11, 2021

jjerphan Nov 11, 2021 •

edited

Loading

jjerphan left a comment

jjerphan Nov 11, 2021 •

edited

Loading

reshamas Nov 15, 2021

thomasjpfan Nov 18, 2021 •

edited

Loading

jjerphan Nov 11, 2021 •

edited

Loading

GaelVaroquaux commented Nov 11, 2021 via email

jjerphan commented Nov 12, 2021

adrinjalali commented Nov 12, 2021

jjerphan commented Nov 12, 2021 •

edited

Loading

rth commented Nov 12, 2021

jjerphan commented Nov 15, 2021 •

edited

Loading

reshamas commented Nov 15, 2021

adrinjalali commented Nov 16, 2021

GaelVaroquaux commented Nov 16, 2021 via email

rth commented Nov 16, 2021

jjerphan commented Nov 17, 2021

adrinjalali commented Nov 17, 2021

jjerphan commented Nov 18, 2021

adrinjalali commented Nov 18, 2021

jjerphan commented Nov 18, 2021 •

edited

Loading

adrinjalali left a comment

jjerphan commented Nov 18, 2021

GaelVaroquaux commented Nov 18, 2021 via email

		Communicators are welcome to participate in `monthly core developer meetings
		<https://github.com/scikit-learn/administrative/tree/master/meeting_notes>`_.

DOC: first draft on the comms #21287

DOC: first draft on the comms #21287

Conversation

GaelVaroquaux commented Oct 8, 2021

GaelVaroquaux commented Oct 8, 2021

reshamas commented Oct 8, 2021

reshamas commented Oct 11, 2021

adrinjalali Oct 11, 2021

Choose a reason for hiding this comment

reshamas Oct 11, 2021

Choose a reason for hiding this comment

jjerphan Nov 11, 2021 • edited Loading

Choose a reason for hiding this comment

jjerphan left a comment

Choose a reason for hiding this comment

jjerphan Nov 11, 2021 • edited Loading

Choose a reason for hiding this comment

reshamas Nov 15, 2021

Choose a reason for hiding this comment

thomasjpfan Nov 18, 2021 • edited Loading

Choose a reason for hiding this comment

jjerphan Nov 11, 2021 • edited Loading

Choose a reason for hiding this comment

GaelVaroquaux commented Nov 11, 2021 via email

jjerphan commented Nov 12, 2021

adrinjalali commented Nov 12, 2021

jjerphan commented Nov 12, 2021 • edited Loading

rth commented Nov 12, 2021

jjerphan commented Nov 15, 2021 • edited Loading

reshamas commented Nov 15, 2021

adrinjalali commented Nov 16, 2021

GaelVaroquaux commented Nov 16, 2021 via email

rth commented Nov 16, 2021

jjerphan commented Nov 17, 2021

adrinjalali commented Nov 17, 2021

jjerphan commented Nov 18, 2021

adrinjalali commented Nov 18, 2021

jjerphan commented Nov 18, 2021 • edited Loading

adrinjalali left a comment

Choose a reason for hiding this comment

jjerphan commented Nov 18, 2021

GaelVaroquaux commented Nov 18, 2021 via email

jjerphan Nov 11, 2021 •

edited

Loading

jjerphan Nov 11, 2021 •

edited

Loading

thomasjpfan Nov 18, 2021 •

edited

Loading

jjerphan Nov 11, 2021 •

edited

Loading

jjerphan commented Nov 12, 2021 •

edited

Loading

jjerphan commented Nov 15, 2021 •

edited

Loading

jjerphan commented Nov 18, 2021 •

edited

Loading