STY Adjusts layout for Authors #15095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please fix the linting errors, as they prevent the page from being rendered in CI. |
|
With the images centred, should the text be centred?
|
On the web left-aligned text is in general recommended (at least for left to right writing languages). This avoids strange behaviors when resizing.... but if you prefer centred... I have no feelings on that. |
thomasjpfan
reviewed
Sep 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR suggests a new layout for the author table
Any other comments?
I have manually modified
authors.rstbecause I have no rights to rungenerate_authors_table_py.Though, script changes are included (it's like I took a bet... let me know...)