Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emeritus core devs final call #13673

Merged
merged 4 commits into from
Apr 20, 2019

Conversation

amueller
Copy link
Member

Closes #13257.

I made every attempt to contact the remaining candidates for emeritus devs. They either replied saying they are happy to become emeritus core devs or didn't reply.

We now officially have 18 core devs!

@amueller
Copy link
Member Author

Looking at the list, it seems like I might have overlooked jmetzen?
Should I reach out to him as well?

doc/authors.rst Outdated
<td>
<a href='https://github.com/amueller'><img src='https://avatars3.githubusercontent.com/u/449558?v=4' class='avatar' /></a> <br />
<p>Andreas Mueller</p>
</td>
<td>
<a href='https://github.com/vene'><img src='https://avatars0.githubusercontent.com/u/241745?v=4' class='avatar' /></a> <br />
<p>Vlad Niculae</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vlad has made a contribution and some reviews beginning of 2019 I think? Alternatively, if he positively responded to your email, then he is not in the emeritus core dev list above.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I've been emailed about this. In any case, I'm fine with being removed (actually, I just got an email that I have been removed anyway.) I made some small contribs this year but they are not significant.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, sorry @vene, That was my fault, I don't think you should have been removed!

@TomDLT
Copy link
Member

TomDLT commented Apr 18, 2019

It seems that a few persons have been lost in current changes:

  • Wei Li
  • Paolo Losi
  • Gilles Louppe
  • Jarrod Millman
  • Vlad Niculae
  • Fabian Pedregosa
  • Peter Prettenhofer
  • Jacob Schreiber

@jnothman
Copy link
Member

@vene may I suggest you not move to emeritus if you expect to be able to lend your approval to future PRs? I realise you are relatively limited in availability. But people able and willing to approve technically complicated are valuable to keep on board, even for intermittent attention. Wdyt?

@vene
Copy link
Member

vene commented Apr 19, 2019

@jnothman I'd be happy to stay on the core team, and definitely expect to be able to weigh in where I can be useful.

Somebody would have to re-add me to https://github.com/orgs/scikit-learn/teams/core-devs/, from where I have been removed yesterday.

@amueller what are your thoughts? did I miss some e-mail about this?

@amueller
Copy link
Member Author

@vene likely to be a misclick by me. this bookkeeping has been tricky :-/

@amueller
Copy link
Member Author

amueller commented Apr 19, 2019

@vene added you back, my apologies!

@vene
Copy link
Member

vene commented Apr 19, 2019 via email

Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always add someone back if we want.

@qinhanmin2014 qinhanmin2014 merged commit 58927cf into scikit-learn:master Apr 20, 2019
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Apr 25, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GOV sent out pings for emeritus core devs.
7 participants