-
-
Notifications
You must be signed in to change notification settings - Fork 25.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emeritus core devs final call #13673
Emeritus core devs final call #13673
Conversation
Looking at the list, it seems like I might have overlooked jmetzen? |
doc/authors.rst
Outdated
<td> | ||
<a href='https://github.com/amueller'><img src='https://avatars3.githubusercontent.com/u/449558?v=4' class='avatar' /></a> <br /> | ||
<p>Andreas Mueller</p> | ||
</td> | ||
<td> | ||
<a href='https://github.com/vene'><img src='https://avatars0.githubusercontent.com/u/241745?v=4' class='avatar' /></a> <br /> | ||
<p>Vlad Niculae</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vlad has made a contribution and some reviews beginning of 2019 I think? Alternatively, if he positively responded to your email, then he is not in the emeritus core dev list above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I've been emailed about this. In any case, I'm fine with being removed (actually, I just got an email that I have been removed anyway.) I made some small contribs this year but they are not significant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn, sorry @vene, That was my fault, I don't think you should have been removed!
It seems that a few persons have been lost in current changes:
|
@vene may I suggest you not move to emeritus if you expect to be able to lend your approval to future PRs? I realise you are relatively limited in availability. But people able and willing to approve technically complicated are valuable to keep on board, even for intermittent attention. Wdyt? |
@jnothman I'd be happy to stay on the core team, and definitely expect to be able to weigh in where I can be useful. Somebody would have to re-add me to https://github.com/orgs/scikit-learn/teams/core-devs/, from where I have been removed yesterday. @amueller what are your thoughts? did I miss some e-mail about this? |
@vene likely to be a misclick by me. this bookkeeping has been tricky :-/ |
@vene added you back, my apologies! |
Thanks, no worries!
…On Fri, Apr 19, 2019, 15:45 Andreas Mueller ***@***.***> wrote:
@vene <https://github.com/vene> added you back, my appollogies!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13673 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB3AUOWNSMV6BTFMXRL7LLPRHLKDANCNFSM4HHAF6RA>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can always add someone back if we want.
This reverts commit 3bb3ca2.
This reverts commit 3bb3ca2.
Closes #13257.
I made every attempt to contact the remaining candidates for emeritus devs. They either replied saying they are happy to become emeritus core devs or didn't reply.
We now officially have 18 core devs!