[MRG+1] Generated author list from github #11708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: AUTHORS.rst doc/Makefile
|
We may need to hard code some extra names. |
qinhanmin2014
approved these changes
Aug 4, 2018
qinhanmin2014
changed the title
|
bthirion, duborg etc don't have their real names shown. |
|
Otherwise LGTM |
jnothman
reviewed
Aug 13, 2018
There was a problem hiding this comment.
I think we need to move gen_authors.py to some kind of maint_tools directory. (I/we have some other candidate scripts to go there.) It requires an introductory comment.
I also think this should be mentioned in doc/developers/maintainer.rst as something to do before release.
|
Update: rendered |
|
We could just keep this all under build_tools?
|
I think that would be better indeed. |
jnothman
approved these changes
Sep 12, 2018
|
Thanks! |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Sep 17, 2018
This was referenced Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR take over the nice generated author list of #4842.
Closes #4842
It lists the members of the "core-dev" and "reviewer" teams.
It is sorted by alphabetical order of
loginslast names.It is supposed to be run each time we add someone in the team.
Note that the list is slightly different from the current one, as detailed below.
We might want to include these people in the "core-dev team".
In the authors list and not in the "core-dev team":
In the "core-dev team" and not in the authors list: