Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public property for start angle? #17

Closed
MirstrKot opened this issue Oct 17, 2017 · 2 comments
Closed

Public property for start angle? #17

MirstrKot opened this issue Oct 17, 2017 · 2 comments

Comments

@MirstrKot
Copy link

Is it possible change start angle from 0,0,0 to the center of my spherical picture? I found random picture in google to illustrate it: For example http://paulbourke.net/fun/dragongardens/2.jpg
the gates is the most important part of panorama and I want to start viewing from the center of image.
@MirstrKot MirstrKot mentioned this issue Oct 18, 2017
Closed
@MirstrKot
Copy link
Author

I made pull request. Please review it, is it good enough or need some improvements.

scihant added a commit that referenced this issue Oct 19, 2017
@scihant
Added startAngle parameter for #17
5b91d0d
@scihant
Copy link
Owner

scihant commented Oct 19, 2017

Thanks for the pull request but I haven't seen it until now sorry for the late response.
I had already added the property on the dev branch but haven't pushed it yet.

The main difference from your implementation is that it takes the value as radians since that's the standard unit when dealing with APIs like this.

I'll review your PR anyway.

@scihant scihant closed this as completed Oct 19, 2017
scihant added a commit that referenced this issue Oct 19, 2017
@scihant
Added startAngle parameter for #17
ef12539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scihant @MirstrKot