Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend the audio property's range to include MusicRecording #2420

Closed
vholland opened this issue Dec 9, 2019 · 2 comments
Closed

Extend the audio property's range to include MusicRecording #2420

vholland opened this issue Dec 9, 2019 · 2 comments
Assignees
@vholland
Labels
schema.org vocab General top level tag for issues on the vocabulary

Comments

@vholland
Copy link
Contributor

vholland commented Dec 9, 2019

The audio property currently expects the value to either be an AudioObject or a Clip, but there are times when a work may embed a song for which there isn't a separate AudioObject to link to.

I propose adding MusicRecording to the range so authors can specify the song without having to have a separate, downloadable file.
@vholland vholland self-assigned this Dec 9, 2019
@vholland vholland added schema.org vocab General top level tag for issues on the vocabulary type:exact proposal labels Dec 9, 2019
vholland added a commit to vholland/schemaorg that referenced this issue Dec 10, 2019
@vholland
Issue schemaorg#2420: Added MusicRecording to the range for audio.
e3bfb1d
@vholland
Copy link
Contributor Author

Implemented as PR #2424

@vholland vholland mentioned this issue Dec 19, 2019
Closed
16 tasks
danbri pushed a commit that referenced this issue Jan 2, 2020
@vholland @danbri
Issue #2420: Added MusicRecording to the range for audio. (#2424)
f113519 
* Issue #2341: Added SportsTeam to the domain for gender.

* Remove file added to wrong branch.

* Issue #2420: Added MusicRecording to the range for audio.

* Added to the range rather than the domain.
@vholland
Copy link
Contributor Author

Included in schema.org 6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vholland vholland

Labels
schema.org vocab General top level tag for issues on the vocabulary
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vholland