Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect ash, the default shell for Alpine Linux. Close #19 #20

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Detect ash, the default shell for Alpine Linux. Close #19 #20

merged 1 commit into from
Mar 6, 2019

Conversation

Congee
Copy link
Contributor

@Congee Congee commented Mar 6, 2019

see #19

uranusjr
uranusjr reviewed Mar 6, 2019
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ash is a variant of ah, so better classified under Bourne IMO. Otherwise 👍

@Congee
Copy link
Contributor Author

Congee commented Mar 6, 2019

Appended 'ash' to the first line. Dude, I have no idea how to order names of these shells.

@uranusjr
Copy link
Member

uranusjr commented Mar 6, 2019

The order doesn’t make sense 🤣 Don’t think too much about it.

@uranusjr uranusjr merged commit 40baf33 into sarugaku:master Mar 6, 2019
uranusjr added a commit that referenced this pull request Mar 6, 2019
@uranusjr
Add news for #20
345daab
@uranusjr
Copy link
Member

uranusjr commented Mar 6, 2019

1.3.0 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uranusjr uranusjr uranusjr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Congee @uranusjr