Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang_log implementation #646

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Add clang_log implementation #646

merged 2 commits into from
Nov 28, 2024

Conversation

DDAN-17
Copy link
Contributor

@DDAN-17 DDAN-17 commented Nov 17, 2024

Just a simple logger I made

@KodrAus
Copy link
Contributor

KodrAus commented Nov 28, 2024

Thanks @DDAN-17! Just a heads up, it looks like your Cargo.toml has the wrong value for your repository URL. It's pointing to https://github.com/DDAN-17/clang-log instead of https://github.com/DDAN-17/clang_log. Honestly... Rust should've just required crate names be valid identifiers, but that's a topic for another day 😄

@KodrAus KodrAus merged commit 8abe775 into rust-lang:master Nov 28, 2024
14 checks passed
@DDAN-17
Copy link
Contributor Author

DDAN-17 commented Nov 28, 2024

Thanks! I just fixed that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DDAN-17 @KodrAus