Implement conversions between Option<Level> and LevelFilter #644
Conversation
This is nice to have when working with the `log` crate, as it allows for more ergonomic conversions between the two types. Specifically, This allows type bounds that require Into<LevelFilter> or Into<Option<Level>> to be used. This in turn makes it possible to write more generic code that can work with tracing and log crates interchangeably. Specifically, this supports some ideas in clap-rs/clap-verbosity-flag#121
|
You may write: |
| fn from(level: Option<Level>) -> LevelFilter { | ||
| match level { | ||
| Some(level) => level.to_level_filter(), | ||
| None => LevelFilter::Off, |
There was a problem hiding this comment.
I'm sure this is always going to be obvious.
There was a problem hiding this comment.
Did you leave out "not" or are you disagreeing with the comment above here and saying that this is actually fine and a reasonable choice to convert Option<Level>::None to LevelFilter::Off?
Is None indicating a default, or the absence of a level? The benefit of making None -> Off is that it round trips. Perhaps a doc comment about this would be sufficient.
There's no |
|
BTW, I solved the underlying need for this through another means (changed the trait associated type bounds), so I'm unblocked from an implementation perspective for now at least. |
This is nice to have when working with the
logcrate, as it allowsfor more ergonomic conversions between the two types. Specifically, This
allows type bounds that require Into or Into<Option>
to be used. This in turn makes it possible to write more generic code
that can work with tracing and log crates interchangeably.
Specifically, this supports some ideas in
clap-rs/clap-verbosity-flag#121