thead_sync.c: directly pass the execution context to yield

byroot · byroot · commit ff831eb0572b · 2025-12-12T10:08:05.000+01:00
Saves one more call to GET_EC()
diff --git a/internal/vm.h b/internal/vm.h
@@ -69,6 +69,7 @@ const char *rb_type_str(enum ruby_value_type type);
 VALUE rb_check_funcall_default(VALUE, ID, int, const VALUE *, VALUE);
 VALUE rb_check_funcall_basic_kw(VALUE, ID, VALUE, int, const VALUE*, int);
 VALUE rb_yield_1(VALUE val);
+VALUE rb_ec_yield(struct rb_execution_context_struct *ec, VALUE val);
 VALUE rb_yield_force_blockarg(VALUE values);
 VALUE rb_lambda_call(VALUE obj, ID mid, int argc, const VALUE *argv,
                      rb_block_call_func_t bl_proc, int min_argc, int max_argc,
diff --git a/thread_sync.c b/thread_sync.c
@@ -650,7 +650,6 @@ rb_mutex_sleep(VALUE self, VALUE timeout)
     return rb_mut_sleep(GET_EC(), self, timeout);
 }
 
-
 VALUE
 rb_mutex_synchronize(VALUE self, VALUE (*func)(VALUE arg), VALUE arg)
 {
@@ -660,6 +659,12 @@ rb_mutex_synchronize(VALUE self, VALUE (*func)(VALUE arg), VALUE arg)
     return rb_ec_ensure(args.ec, func, arg, do_mutex_unlock_safe, (VALUE)&args);
 }
 
+static VALUE
+do_ec_yield(VALUE _ec)
+{
+    return rb_ec_yield((rb_execution_context_t *)_ec, Qundef);
+}
+
 VALUE
 rb_mut_synchronize(rb_execution_context_t *ec, VALUE self)
 {
@@ -669,7 +674,7 @@ rb_mut_synchronize(rb_execution_context_t *ec, VALUE self)
         .ec = ec,
     };
     do_mutex_lock(&args, 1);
-    return rb_ec_ensure(args.ec, rb_yield, Qundef, do_mutex_unlock_safe, (VALUE)&args);
+    return rb_ec_ensure(args.ec, do_ec_yield, (VALUE)ec, do_mutex_unlock_safe, (VALUE)&args);
 }
 
 void
diff --git a/vm_eval.c b/vm_eval.c
@@ -1379,6 +1379,17 @@ rb_yield(VALUE val)
     }
 }
 
+VALUE
+rb_ec_yield(rb_execution_context_t *ec, VALUE val)
+{
+    if (UNDEF_P(val)) {
+        return vm_yield(ec, 0, NULL, RB_NO_KEYWORDS);
+    }
+    else {
+        return vm_yield(ec, 1, &val, RB_NO_KEYWORDS);
+    }
+}
+
 #undef rb_yield_values
 VALUE
 rb_yield_values(int n, ...)

Original file line number	Diff line number	Diff line change
`@@ -650,7 +650,6 @@ rb_mutex_sleep(VALUE self, VALUE timeout)`
`650`	`650`	`return rb_mut_sleep(GET_EC(), self, timeout);`
`651`	`651`	`}`
`652`	`652`
`653`		`-`
`654`	`653`	`VALUE`
`655`	`654`	`rb_mutex_synchronize(VALUE self, VALUE (*func)(VALUE arg), VALUE arg)`
`656`	`655`	`{`
`@@ -660,6 +659,12 @@ rb_mutex_synchronize(VALUE self, VALUE (*func)(VALUE arg), VALUE arg)`
`660`	`659`	`return rb_ec_ensure(args.ec, func, arg, do_mutex_unlock_safe, (VALUE)&args);`
`661`	`660`	`}`
`662`	`661`
	`662`	`+static VALUE`
	`663`	`+do_ec_yield(VALUE _ec)`
	`664`	`+{`
	`665`	`+ return rb_ec_yield((rb_execution_context_t *)_ec, Qundef);`
	`666`	`+}`
	`667`	`+`
`663`	`668`	`VALUE`
`664`	`669`	`rb_mut_synchronize(rb_execution_context_t *ec, VALUE self)`
`665`	`670`	`{`
`@@ -669,7 +674,7 @@ rb_mut_synchronize(rb_execution_context_t *ec, VALUE self)`
`669`	`674`	`.ec = ec,`
`670`	`675`	`};`
`671`	`676`	`do_mutex_lock(&args, 1);`
`672`		`- return rb_ec_ensure(args.ec, rb_yield, Qundef, do_mutex_unlock_safe, (VALUE)&args);`
	`677`	`+ return rb_ec_ensure(args.ec, do_ec_yield, (VALUE)ec, do_mutex_unlock_safe, (VALUE)&args);`
`673`	`678`	`}`
`674`	`679`
`675`	`680`	`void`