Fix binding.implicit_parameters_get/defined segfault when wrong name string is passed (#15530)

tompng · web-flow · commit b8ba9cebb947 · 2025-12-13T01:40:49.000+09:00
diff --git a/proc.c b/proc.c
@@ -725,7 +725,7 @@ bind_implicit_parameter_get(VALUE bindval, VALUE sym)
 
     if (!lid || !rb_implicit_param_p(lid)) {
         rb_name_err_raise("'%1$s' is not an implicit parameter",
-                          bindval, ID2SYM(lid));
+                          bindval, sym);
     }
 
     GetBindingPtr(bindval, bind);
@@ -774,7 +774,7 @@ bind_implicit_parameter_defined_p(VALUE bindval, VALUE sym)
 
     if (!lid || !rb_implicit_param_p(lid)) {
         rb_name_err_raise("'%1$s' is not an implicit parameter",
-                          bindval, ID2SYM(lid));
+                          bindval, sym);
     }
 
     GetBindingPtr(bindval, bind);
diff --git a/test/ruby/test_proc.rb b/test/ruby/test_proc.rb
@@ -1913,6 +1913,14 @@ def test_implicit_parameters_for_it_and_numparams
     end
   end
 
+  def test_implicit_parameter_invalid_name
+    message_pattern = /is not an implicit parameter/
+    assert_raise_with_message(NameError, message_pattern) { binding.implicit_parameter_defined?(:foo) }
+    assert_raise_with_message(NameError, message_pattern) { binding.implicit_parameter_get(:foo) }
+    assert_raise_with_message(NameError, message_pattern) { binding.implicit_parameter_defined?("wrong_implicit_parameter_name_#{rand(10000)}") }
+    assert_raise_with_message(NameError, message_pattern) { binding.implicit_parameter_get("wrong_implicit_parameter_name_#{rand(10000)}") }
+  end
+
   def test_local_variable_set_wb
     assert_ruby_status([], <<-'end;', '[Bug #13605]', timeout: 30)
       b = binding

Original file line number	Diff line number	Diff line change
`@@ -725,7 +725,7 @@ bind_implicit_parameter_get(VALUE bindval, VALUE sym)`
`725`	`725`
`726`	`726`	`if (!lid \|\| !rb_implicit_param_p(lid)) {`
`727`	`727`	`rb_name_err_raise("'%1$s' is not an implicit parameter",`
`728`		`- bindval, ID2SYM(lid));`
	`728`	`+ bindval, sym);`
`729`	`729`	`}`
`730`	`730`
`731`	`731`	`GetBindingPtr(bindval, bind);`
`@@ -774,7 +774,7 @@ bind_implicit_parameter_defined_p(VALUE bindval, VALUE sym)`
`774`	`774`
`775`	`775`	`if (!lid \|\| !rb_implicit_param_p(lid)) {`
`776`	`776`	`rb_name_err_raise("'%1$s' is not an implicit parameter",`
`777`		`- bindval, ID2SYM(lid));`
	`777`	`+ bindval, sym);`
`778`	`778`	`}`
`779`	`779`
`780`	`780`	`GetBindingPtr(bindval, bind);`