Do not colorize partially-correct inspect

k0kubun · k0kubun · commit a5804c3560bb · 2020-12-28T23:21:10.000-08:00
This is to prevent a yellow-mixed output for ActiveSupport::TimeWithZone. Follows up #159 and ruby/ruby#3967.
diff --git a/lib/irb/color.rb b/lib/irb/color.rb
@@ -71,6 +71,9 @@ module Color
     end
     private_constant :TOKEN_SEQ_EXPRS
 
+    ERROR_TOKENS = TOKEN_SEQ_EXPRS.keys.select { |k| k.to_s.end_with?('error') }
+    private_constant :ERROR_TOKENS
+
     class << self
       def colorable?
         $stdout.tty? && supported? && (/mswin|mingw/ =~ RUBY_PLATFORM || (ENV.key?('TERM') && ENV['TERM'] != 'dumb'))
@@ -119,6 +122,11 @@ def colorize_code(code, complete: true, ignore_error: false)
         length = 0
 
         scan(code, allow_last_error: !complete) do |token, str, expr|
+          # IRB::ColorPrinter skips colorizing fragments with any invalid token
+          if ignore_error && ERROR_TOKENS.include?(token)
+            return Reline::Unicode.escape_for_print(code)
+          end
+
           in_symbol = symbol_state.scan_token(token)
           str.each_line do |line|
             line = Reline::Unicode.escape_for_print(line)
@@ -188,7 +196,7 @@ def scan(code, allow_last_error:)
       end
 
       def dispatch_seq(token, expr, str, in_symbol:, ignore_error:)
-        if token == :on_parse_error or token == :compile_error
+        if ERROR_TOKENS.include?(token)
           ignore_error ? nil : TOKEN_SEQ_EXPRS[token][0]
         elsif in_symbol
           [YELLOW]
