Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubocop/rubocop-rspec
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.0.4
Choose a base ref
...
head repository: rubocop/rubocop-rspec
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.1.0
Choose a head ref
  • 18 commits
  • 19 files changed
  • 8 contributors

Commits on Aug 8, 2024

  1. Fix false-negative and error for RSpec/MetadataStyle 

    When RSpec/MetadataStyle cop is used with `EnforcedStyle: hash`,
offenses must be registered only for metadata arguments being symbols.

It was previously producing an exception if a variable was used in the
metadata arguments (except if it was the last one).
    @cbliard
    cbliard committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    dbd87bb View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1947 from cbliard/fix-metadata-style-cop-with-non… 

    …-literal-args

Fix false-negative and error for `RSpec/MetadataStyle`
    @pirj
    pirj authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    e02576f View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Improve offense message for RSpec/IndexedLet 

    Ran into this offense and thought:
> Where exactly does my name contain "index"?

I believe this message format is more clear.
    @Earlopain
    Earlopain committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f31b268 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Merge pull request #1953 from Earlopain/offense-message-indexed-let 

    Improve offense message for `RSpec/IndexedLet`
    @pirj
    pirj authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    74d7837 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Release v3.0.5

    @bquorning
    bquorning committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    a8a061c View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1956 from rubocop/release 

    Release v3.0.5
    @bquorning
    bquorning authored Sep 7, 2024
    Configuration menu
    Copy the full SHA
    16cf19c View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Sort RuboCop config file

    @corsonknowles @bquorning
    corsonknowles authored and bquorning committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9a90279 View commit details
    Browse the repository at this point in the history

  2. Fix InternalAffairs/RedundantSourceRange offenses

    @bquorning
    bquorning committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f4f698c View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1959 from rubocop/fix-RedundantSourceRange-offenses 

    Fix InternalAffairs/RedundantSourceRange offenses
    @bquorning
    bquorning authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5b91d18 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #1958 from rubocop/cop-config-order 

    Sort RuboCop config file
    @bquorning
    bquorning authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    cf0ac65 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. fix false positive on UnspecifiedException cop when function is named… 

    … raise_exception
    @aarestad
    aarestad committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a59315f View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1960 from aarestad/unspecified-exception-fix 

    RSpec/UnspecifiedException: break on non-send blocks to avoid false positives on functions named `raise_exception`
    @bquorning
    bquorning authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    79e0bf7 View commit details
    Browse the repository at this point in the history

  3. test: showcase RSpec/UnspecifiedException block/chain confusion is … 

    …fixed
    @G-Rath
    G-Rath committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1f48c7b View commit details
    Browse the repository at this point in the history

  4. Merge pull request #1962 from G-Rath/add-spec 

    test: showcase `RSpec/UnspecifiedException` block/chain confusion is fixed
    @bquorning
    bquorning authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5959ad6 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Add RSpec/StringAsInstanceDoubleConstant 

    Addresses #1136

Adds a cop which can autocorrect from String declarations for instance_double to Class declarations. Symbol declarations are not affected.
    @corsonknowles
    corsonknowles committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    324552c View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Merge pull request #1957 from corsonknowles/master 

    Add RSpec/StringAsInstanceDoubleConstant
    @bquorning
    bquorning authored Sep 28, 2024
    Configuration menu
    Copy the full SHA
    dea7de9 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Bump version to v3.1.0

    @bquorning
    bquorning committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    34c042e View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1963 from rubocop/release 

    Bump version to v3.1.0
    @bquorning
    bquorning authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    5e06176 View commit details
    Browse the repository at this point in the history
Loading