You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There seems to be inconsistencies with whether Rails/ActionControllerTestCase is regarded as a safe auto-correct or not.
Expected behavior
Rails/ActionControllerTestCase is described as unsafe (This cop’s autocorrection is unsafe because the API of each test case class is different. Make sure to update each test of your controller test cases after changing the superclass.), so it shouldn't be applied when rubocop --autocorrect is run.
Actual behavior
Cop is applied.
Steps to reproduce the problem
Create a test that inherits from ActionController::TestCase
Run only safe rubocops (bundle exec rubocop --autocorrct)
ActionController::TestCase is now replaced with ActionDispatch::IntegrationTest
RuboCop version
Include the output of rubocop -V or bundle exec rubocop -V if using Bundler. Here's an example:
You can see extension cop versions (e.g. rubocop-rails, rubocop-performance, and others) output by rubocop -V,
include them as well. Here's an example:
There seems to be inconsistencies with whether
Rails/ActionControllerTestCase
is regarded as a safe auto-correct or not.Expected behavior
Rails/ActionControllerTestCase is described as unsafe (This cop’s autocorrection is unsafe because the API of each test case class is different. Make sure to update each test of your controller test cases after changing the superclass.), so it shouldn't be applied when
rubocop --autocorrect
is run.Actual behavior
Cop is applied.
Steps to reproduce the problem
ActionController::TestCase
bundle exec rubocop --autocorrct
)ActionController::TestCase
is now replaced withActionDispatch::IntegrationTest
RuboCop version
Include the output of
rubocop -V
orbundle exec rubocop -V
if using Bundler. Here's an example:You can see extension cop versions (e.g. rubocop-rails, rubocop-performance, and others) output by rubocop -V,
include them as well. Here's an example:
The text was updated successfully, but these errors were encountered: