Skip to content

Rails/ActionControllerTestCase doesn't work for non-empty classes #786

Closed
@vlad-pisanov

Description

Consider

class C1 < ActionController::TestCase
end

class C2 < ActionController::TestCase
  def test_foo
  end
end

Rails/ActionControllerTestCase flags C1 as an offense, but not C2.

Expected

Both C1 and C2 should be flagged since they inherit from the obsolete ActionController::TestCase

RuboCop version

1.34.1 (using Parser 3.1.2.1, rubocop-ast 1.21.0, running on ruby 2.6.9 x86_64-darwin21)
  - rubocop-minitest 0.21.0
  - rubocop-performance 1.14.3
  - rubocop-rails 2.15.2

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions