Skip to content

Rails/SkipsModelValidations false positive when using upsert #1286

Closed
@hirowatari

Description

I'm getting a false positive for Rails/SkipsModelValidations. I have other classes that have the method upsert.


Expected behavior

No offences detected

Actual behavior

Offenses detected

Steps to reproduce the problem

# frozen_string_literal: true

class Example # not a active record model
  def self.upsert(args)
    # do something
  end
end

Example.upsert(shop)

bundle exec rubocop ./example.rb
output:

Inspecting 1 file
C

Offenses:

example.rb:9:9: C: Rails/SkipsModelValidations: Avoid using upsert because it skips validations. (https://guides.rubyonrails.org/active_record_validations.html#skipping-validations)
Example.upsert(shop)
        ^^^^^^

1 file inspected, 1 offense detected

RuboCop version

$ bundle exec rubocop -V
1.64.0 (using Parser 3.3.1.0, rubocop-ast 1.31.3, running on ruby 3.2.4) +server [x86_64-linux]
  - rubocop-capybara 2.20.0
  - rubocop-factory_bot 2.25.1
  - rubocop-graphql 1.5.1
  - rubocop-performance 1.21.0
  - rubocop-rails 2.25.0
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.29.2
  - rubocop-rspec_rails 2.28.3
  - rubocop-thread_safety 0.5.1

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions