Skip to content

Performance/MapCompact autocorrect is too greedy #238

@jcoyne

Description

@jcoyne

I ran the autocorrect on this code and it removed the trailing end as well as the .join("\n"). This results in a syntax error.

   def participant_change_description
     %i[added_managers added_depositors added_reviewers
-       removed_managers removed_depositors removed_reviewers].map do |field_name|
+       removed_managers removed_depositors removed_reviewers].filter_map do |field_name|
       field_changes = send(field_name)
       next if field_changes.blank?

       "#{field_name.to_s.humanize}: #{field_changes.map(&:sunetid).join(', ')}"
-    end.compact.join("\n")
   end

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions