Handle implicit receivers in Style/InvertibleUnlessCondition

sambostock · bbatsov · commit 5da1905ce6b7 · 2024-02-28T15:46:36.000+02:00
Previously, we would attempt to call `node.receiver.source`, but
`node.receiver` could be `nil`.

This teaches the cop to handle implicit receivers.
diff --git a/changelog/fix_handle_implicit_receivers_in.md b/changelog/fix_handle_implicit_receivers_in.md
@@ -0,0 +1 @@
+* [#12711](https://github.com/rubocop/rubocop/pull/12711): Handle implicit receivers in `Style/InvertibleUnlessCondition`. ([@sambostock][])
diff --git a/lib/rubocop/cop/style/invertible_unless_condition.rb b/lib/rubocop/cop/style/invertible_unless_condition.rb
@@ -99,23 +99,23 @@ def preferred_condition(node)
           end
         end
 
-        def preferred_send_condition(node)
-          receiver_source = node.receiver.source
+        def preferred_send_condition(node) # rubocop:disable Metrics/CyclomaticComplexity
+          receiver_source = node.receiver&.source
           return receiver_source if node.method?(:!)
 
+          receive = receiver_source ? "#{receiver_source}." : '' # receiver may be implicit (self)
+
           inverse_method_name = inverse_methods[node.method_name]
-          return "#{receiver_source}.#{inverse_method_name}" unless node.arguments?
+          return "#{receive}#{inverse_method_name}" unless node.arguments?
 
           argument_list = node.arguments.map(&:source).join(', ')
           if node.operator_method?
             return "#{receiver_source} #{inverse_method_name} #{argument_list}"
           end
 
-          if node.parenthesized?
-            return "#{receiver_source}.#{inverse_method_name}(#{argument_list})"
-          end
+          return "#{receive}#{inverse_method_name}(#{argument_list})" if node.parenthesized?
 
-          "#{receiver_source}.#{inverse_method_name} #{argument_list}"
+          "#{receive}#{inverse_method_name} #{argument_list}"
         end
 
         def preferred_logical_condition(node)
diff --git a/spec/rubocop/cop/style/invertible_unless_condition_spec.rb b/spec/rubocop/cop/style/invertible_unless_condition_spec.rb
@@ -91,6 +91,39 @@
     end
   end
 
+  it 'registers an offense and corrects methods without arguments called with implicit receivers' do
+    expect_offense(<<~RUBY)
+      foo unless odd?
+      ^^^^^^^^^^^^^^^ Prefer `if even?` over `unless odd?`.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      foo if even?
+    RUBY
+  end
+
+  it 'registers an offense and corrects parenthesized methods with arguments called with implicit receivers' do
+    expect_offense(<<~RUBY)
+      foo unless include?(value)
+      ^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `if exclude?(value)` over `unless include?(value)`.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      foo if exclude?(value)
+    RUBY
+  end
+
+  it 'registers an offense and corrects unparenthesized methods with arguments called with implicit receivers' do
+    expect_offense(<<~RUBY)
+      foo unless include? value
+      ^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `if exclude? value` over `unless include? value`.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      foo if exclude? value
+    RUBY
+  end
+
   it 'does not register an offense when using explicit begin condition' do
     expect_no_offenses(<<~RUBY)
       foo unless begin x != y end

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+* [#12711](https://github.com/rubocop/rubocop/pull/12711): Handle implicit receivers in `Style/InvertibleUnlessCondition`. ([@sambostock][])