add pihph_article() #362
Merged
add pihph_article() #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @stefanocoretta, I planned to review on Monday. Is it closed on purpose ? Do you still suggest we add this format into the package? |
|
Hi! Same as with |
cderv
requested changes
Jan 5, 2021
There was a problem hiding this comment.
Thanks for the contribution !
I made a few comments to improve and one thing you must fix : currently adding a bibliography file will fail the rendering. This is because some Pandoc stuff are missing that you need when Pandoc citeproc is used. Your default does not use bibtex or natbib here but Pandoc citeproc.
Thanks!
Co-authored-by: Christophe Dervieux <[email protected]>
In case user removes `gloss` in the yaml preamble. Co-authored-by: Christophe Dervieux <[email protected]>
Co-authored-by: Christophe Dervieux <[email protected]>
Co-authored-by: Christophe Dervieux <[email protected]>
cderv
reviewed
Jan 6, 2021
cderv
reviewed
Jan 6, 2021
Co-authored-by: Christophe Dervieux <[email protected]>
|
Thanks for checking on this! I will work on the other changes in the next days. |
added 6 commits
January 6, 2021 16:30
cderv
reviewed
Jan 8, 2021
cderv
requested changes
Jan 18, 2021
This was referenced Jan 18, 2021
stefanocoretta
pushed a commit
to stefanocoretta/rticles
that referenced
this pull request
Apr 3, 2021
Co-authored-by: Christophe Dervieux <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request adds
pihph_article()for articles of Papers in Historical Phonology (PiHPh).✅ R CMD check succeeded.
✅ Pull request check list:
Unless you have done it in any other RStudio's projects before, please sign the individual or corporate contributor agreement for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). You can send the signed copy to [email protected].
Add the
journalname_article()function toR/article.Rif the output format is simple enough, otherwise create a separateR/journalname_article.R.Add the Pandoc LaTeX template
inst/rmarkdown/templates/journalname/resources/template.tex.Add a skeleton article
inst/rmarkdown/templates/journalname/skeleton/skeleton.Rmd.Add a description of the template
inst/rmarkdown/templates/journalname/template.yaml.Please include the document class file (
*.cls) if needed, but please do not include standard LaTeX packages (*.sty) that can be downloaded from CTAN. If you are using TinyTeX or TeX Live, you can verify if a package is available on CTAN viatinytex::parse_packages(files = "FILENAME"")(e.g., whenFILENAMEisplain.bst, it should return"bibtex", which means this file is from a standard CTAN package). Please keep the number of new files absolutely minimal (e.g., do not include PDF output files), and also make examples minimal (e.g., if you need a.bibexample, try to only leave one or two bibliography entries in it, and don't include too many items in it without using all of them).Update Rd and namespace (could be done by
devtools::document()).Update NEWS.
Update README with a link to the newly supported journal. Please add your Github username and the full name of the journal (follow other examples in the list).
Add a test to
tests/testit/test-formats.Rby adding a linetest_format("journalname"). We try to keep them in alphabetical order.Add your name to the list of authors
Authors@Rin DESCRIPTION. You don't need to bump the package version in DESCRIPTION.