add glossa_article() #361
add glossa_article() #361
Conversation
…eturns the status code 520 (hence causes trouble in our CRAN submission):
> table(replicate(100, attr(curlGetHeaders('https://www.tandf.co.uk/journals/authors/InteractCADLaTeX.zip'), 'status')))
200 520
23 77
Co-authored-by: Christophe Dervieux <[email protected]>
Co-authored-by: Christophe Dervieux <[email protected]>
stefanocoretta
force-pushed
the
glossa-article
branch
from
e683102 to
952b660
Compare
|
@cderv macOS check fails with |
There was a problem hiding this comment.
Thanks a lot for the contribution !
This looks good. But I have still a few questions.
Among the things that needs to be improve, the general feedback I have is that the skeleton needs to have some more content acting as documentation for user.
- The template allows some configuration that are not shown in the skeleton (Pandoc's variable)
- The content of the skeleton is empty, whereas the official template contains a lot of Guidelines that needs to be followed by a user. This should be used in the skeleton as documentation and demo.
- Example Bibliography file is missing to test out that this works correctly with the citation processing (at least the default one)
I'll be happy to answer any questions about this and discuss anything. Feel free to ping me.
Thanks !
Co-authored-by: Christophe Dervieux <[email protected]>
|
I think I implemented all the fixes and changes. Let me know if there's anything else! Thanks for the patience. |
There was a problem hiding this comment.
LGTM!
Just so you know, I adapted the skeleton to show how to use with natbib.
By default, you are using Pandoc's citeproc, the default with pdf_document(). In this case, a # References header will be required so that there is a title for the bibliography. When using biblatex, it seems the class option needs to be activated.
Anyway, this is working, we can adjust later if something is not right.
The pull request adds
glossa_article()for articles of Glossa: a journal of general linguistics (Glossa).✅ R CMD check succeeded.
✅ Pull request check list:
Unless you have done it in any other RStudio's projects before, please sign the individual or corporate contributor agreement for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). You can send the signed copy to [email protected].
Add the
journalname_article()function toR/article.Rif the output format is simple enough, otherwise create a separateR/journalname_article.R.Add the Pandoc LaTeX template
inst/rmarkdown/templates/journalname/resources/template.tex.Add a skeleton article
inst/rmarkdown/templates/journalname/skeleton/skeleton.Rmd.Add a description of the template
inst/rmarkdown/templates/journalname/template.yaml.Please include the document class file (
*.cls) if needed, but please do not include standard LaTeX packages (*.sty) that can be downloaded from CTAN. If you are using TinyTeX or TeX Live, you can verify if a package is available on CTAN viatinytex::parse_packages(files = "FILENAME"")(e.g., whenFILENAMEisplain.bst, it should return"bibtex", which means this file is from a standard CTAN package). Please keep the number of new files absolutely minimal (e.g., do not include PDF output files), and also make examples minimal (e.g., if you need a.bibexample, try to only leave one or two bibliography entries in it, and don't include too many items in it without using all of them).Update Rd and namespace (could be done by
devtools::document()).Update NEWS.
Update README with a link to the newly supported journal. Please add your Github username and the full name of the journal (follow other examples in the list).
Add a test to
tests/testit/test-formats.Rby adding a linetest_format("journalname"). We try to keep them in alphabetical order.Add your name to the list of authors
Authors@Rin DESCRIPTION. You don't need to bump the package version in DESCRIPTION.