.rs.secureDownloadMethod() needs to stop using wininet for newer R

R 4.2.0 has deprecated the use of the "wininet" download method, as per:

https://github.com/wch/r-source/commit/f8f705fe994ee163919d6246af3ae8c48440c65f

We try to force the use of "wininet" here:

https://github.com/rstudio/rstudio/blob/06e7d7d1f2106c295e96126a2da979afbf7b1acf/src/cpp/session/modules/SessionPackages.R#L1324-L1335

For R 4.2.0 and newer, we'll probably want to prefer using "libcurl" (but we should verify that certificates are now properly checked, as per the associated code comment).

	# For windows we prefer binding directly to wininet if we can (since
	# that doesn't rely on the value of setInternet2). If it's R <= 3.1
	# then we can use "internal" for https so long as internet2 is enabled
	# (we don't use libcurl on Windows because it doesn't check certs).
	if (identical(sysName, "Windows")) {
	if (isR32)
	"wininet"
	else if (isTRUE(.rs.setInternet2(NA)))
	"internal"
	else
	""
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

.rs.secureDownloadMethod() needs to stop using wininet for newer R #10163

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development