Skip to content

.rs.secureDownloadMethod() needs to stop using wininet for newer R #10163

New issue
New issue
Closed
#10301
Closed
.rs.secureDownloadMethod() needs to stop using wininet for newer R#10163
#10301
Assignees
jgutmanronblum
Labels
enhancementgood first issuer versions
Milestone
Prairie Trillium (2022.02.0)
@kevinushey

Description

@kevinushey
kevinushey
opened on Nov 30, 2021

R 4.2.0 has deprecated the use of the "wininet" download method, as per:

wch/r-source@f8f705f

We try to force the use of "wininet" here:

rstudio/src/cpp/session/modules/SessionPackages.R

Lines 1324 to 1335 in 06e7d7d

# For windows we prefer binding directly to wininet if we can (since
# that doesn't rely on the value of setInternet2). If it's R <= 3.1
# then we can use "internal" for https so long as internet2 is enabled
# (we don't use libcurl on Windows because it doesn't check certs).
if (identical(sysName, "Windows")) {
if (isR32)
"wininet"
else if (isTRUE(.rs.setInternet2(NA)))
"internal"
else
""
}

For R 4.2.0 and newer, we'll probably want to prefer using "libcurl" (but we should verify that certificates are now properly checked, as per the associated code comment).

Metadata

Metadata

Assignees

Labels

enhancementgood first issuer versions

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions