Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card and button lack hover effect #26

Closed
rishipurwar1 opened this issue Sep 18, 2021 · 25 comments
Closed

Card and button lack hover effect #26

rishipurwar1 opened this issue Sep 18, 2021 · 25 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest improvement improvements to UI

Comments

@rishipurwar1
Copy link
Owner

rishipurwar1 commented Sep 18, 2021

Describe the improvement

If you hover over any of the cards and buttons, they don't show a hover effect.

Expected behavior

Add a hover effect to cards and buttons to make things smoother.

If anyone wants to work on this issue, please let me know in the comment.

@rishipurwar1 rishipurwar1 added bug Something isn't working good first issue Good for newcomers hacktoberfest improvement improvements to UI labels Sep 18, 2021
@mehmettemel
Copy link

I can work on it

@rishipurwar1
Copy link
Owner Author

@mehmettemel assigned to you.

@rishipurwar1
Copy link
Owner Author

rishipurwar1 commented Sep 18, 2021

You need to add hover effect to all the cards(challenges, solutions, resources)
If you need help, please let me know.

@mehmettemel
Copy link

I have created firestore project for .env but cannot reach firestore data backend.I m only seeing skeleton cards

@rishipurwar1
Copy link
Owner Author

rishipurwar1 commented Sep 19, 2021

Hey @mehmettemel,

Can you please share your email id from which you created the firebase project, so I can give you access to the data?
If you don't want to share your email id over here you can message me on LinkedIn or Twitter.
You can also join our discord community: https://discord.gg/FYSQUEw6xP

@rishipurwar1
Copy link
Owner Author

Hey @mehmettemel
Which type of hover effect are you planning to add on cards and buttons?

@mehmettemel
Copy link

I am planning to change the background and text color of the card while hovering.I m not gonna change the button background color just make button text color more lighter.

@rishipurwar1
Copy link
Owner Author

rishipurwar1 commented Sep 19, 2021

I am planning to change the background and text color of the card while hovering.I m not gonna change the button background color just make button text color more lighter.

Instead of changing the background and text color of the card. I would suggest you change the box-shadow value or scale up the cards on hover.
or checkout example-2 for inspiration. You can slide it down on hover but don't add an overlay on the cards like in the example.

@rishipurwar1
Copy link
Owner Author

rishipurwar1 commented Sep 19, 2021

I would suggest you explore more examples for inspiration then let me know.
You don't need to add a very fancy hover effect, keep it simple.

@rishipurwar1
Copy link
Owner Author

Feel free to give a Github star⭐️ to this repo.

@rishipurwar1
Copy link
Owner Author

@mehmettemel do you have any experience with eslint and prettier?

@mehmettemel
Copy link

yeah.you can watch traversy media video for this

@rishipurwar1
Copy link
Owner Author

@mehmettemel are you working on this issue?

@aman-sukhwal-7
Copy link
Contributor

I can work on it!

@SAHU-01
Copy link

SAHU-01 commented Oct 1, 2021

If this issue is open i'd like to work on it!

@rishipurwar1
Copy link
Owner Author

@aman-sukhwal-7 are you working on this issue?

@rishipurwar1
Copy link
Owner Author

rishipurwar1 commented Oct 1, 2021

@SAHU-01 If you want, you can work with @aman-sukhwal-7 on this issue.
Both of you can divide this task, lets say you can work on a solutions card or resources card and aman can work on a challenges card.

@SAHU-01
Copy link

SAHU-01 commented Oct 1, 2021

@SAHU-01 If you want, you can work with @aman-sukhwal-7 on this issue. Both of you can divide this task, lets say you can work on a solutions card or resources card and aman can work on a challenges card.

@aman-sukhwal-7 lets dicuss and split the work,if it's ok with you!

@aman-sukhwal-7
Copy link
Contributor

Actually I already resolved this issue!

@SAHU-01
Copy link

SAHU-01 commented Oct 1, 2021

Actually I already resolved this issue!

it's ok then not an issue!

@SAKSHAM-SINGH130
Copy link

I can fix this bug very easily.

@imps1001
Copy link

Hey @rishipurwar1, I can work on this issue if this is still open.

@rishipurwar1
Copy link
Owner Author

rishipurwar1 commented Oct 14, 2021

yes this issue is open. You can work on this one.
Please try to fix this one first.

@SAKSHAM-SINGH130
Copy link

there are some specific codes for it. I can fixed this issue

@rishipurwar1
Copy link
Owner Author

there are some specific codes for it. I can fixed this issue

Issue is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest improvement improvements to UI
Projects
None yet
Development

No branches or pull requests

6 participants