-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix challenge details page blank screen #24
Comments
@rishipurwar1 I can take it up. |
@wsameer assigned to you. |
@rishipurwar1 I am installing the APP and getting this fire-base error?
any help here? |
when did you get this error during npm install or npm start? |
I have pinged you on Twitter. Everything is set-up as per Readme.md, just the credentials to development firebase project are remaining. |
Just added you to the firebase project. |
Please share the gif/image of the changes before committing your code. |
I see that you have added a spinner component already. Would you want me to reuse that? |
I think it'll not look good on the UI. |
Hey @wsameer |
@rishipurwar1 how does this look? p.s: static image won't show animation |
@wsameer It looks good but I think you need to decrease the size of the loader a little bit. |
Just to confirm are you using the Lottie component from the react-lottie npm package? |
Yeah, I am using that only. Also, will reduce the size by 30%. |
About the bug
The challenge details page should show a loading state instead of a blank page while content is loading.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
It should show a loading animation(either an SVG loader or a skeleton loading animation) to fill up a blank space, so users can have a better user experience.
Screenshots
Desktop (please complete the following information):
If Anyone wants to work on this task, please let me know in the comment.
The text was updated successfully, but these errors were encountered: