Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative int parameters for --vpp-ngx-truehdr #649

Closed
k6G52m4Dz75W opened this issue Nov 23, 2024 · 4 comments
Closed

Negative int parameters for --vpp-ngx-truehdr #649

k6G52m4Dz75W opened this issue Nov 23, 2024 · 4 comments

Comments

@k6G52m4Dz75W
Copy link

First of all, thanks for this amazing app!
Though it seems that this ngx-TrueHDR is not the same as RTX Video HDR, it really shares some similiar settings and according to the guide for RTX Video HDR here: https://www.reddit.com/r/nvidia/comments/1b03yfg/rtx_hdr_paper_white_gamma_reference_settings/ , the best default parameters for max luminence of 1000 should be +25 Contrast, -25 Saturation and +44 mid-gray. So would you please add negative int parameters support for this option and default them to the previous numbers?
Thanks in advance. And if I'm wrong, please share me more details on this.
@rigaya
Copy link
Owner

rigaya commented Nov 24, 2024 •
edited
Loading

Thank you for your comments.
I'm using RTX Video SDK 1.0.2 header file to integrate NGX TrueHDR, and the value range for --vpp-ngx-truehdr is based on the definition in the header file, and it seems to have no negative value.

image

I'm pretty unsure if the parameter mapping is the same although it's name is the same.

@k6G52m4Dz75W
Copy link
Author

Thanks for your quick response. I've compared the values in the panel of Nvidia app with the ones in the image you provided, I'm almost sure that they use identical algorithm except that they have different "base" numbers to count. The parameters in the sdk are based on 100 instead of 0, so the equivilant values for max luminence of 1000 should be 125 Contrast, 75 Saturation and 44 MiddleGray. And I've made an experiment with this combination whose result is fantastic. Please consider change the default values to these. Thanks again!

rigaya added a commit that referenced this issue Nov 24, 2024
@rigaya
--vpp-ngx-truehdrのデフォルト値を変更。 ( #649 )
bc17848
@rigaya
Copy link
Owner

rigaya commented Nov 24, 2024

Thank you for sharing the information.

I've applied the changed to the default value of contrast and saturation for --vpp-ngx-truehdr in NVEnc 7.76.

@rigaya
Copy link
Owner

rigaya commented Dec 3, 2024

I'll close the issue as the change has been applied in NVEnc 7.76.

@rigaya rigaya closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rigaya @k6G52m4Dz75W