Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: awarpsharp2 #294

Closed
GregAlanR opened this issue Jan 8, 2021 · 5 comments
Closed

Feature request: awarpsharp2 #294

GregAlanR opened this issue Jan 8, 2021 · 5 comments

Comments

@GregAlanR
Copy link

Would it be possible to add awarpsharp2 or warpsharp filter ?
rigaya added a commit that referenced this issue Jan 31, 2021
@rigaya
細線化フィルタを追加。(--vpp-warpsharp, #294)
ae615e3
@rigaya
Copy link
Owner

rigaya commented Jan 31, 2021

I have added awarpsharp2 like filter --vpp-warpsharp in NVEnc 5.26.

The basic algorithm are the same of awarpsharp, but it is implemented in CUDA some slight difference for optimization in CUDA.

@rigaya rigaya mentioned this issue Jan 31, 2021
Closed
@GregAlanR
Copy link
Author

Works great.

Thank you

@JJKylee JJKylee mentioned this issue Jan 31, 2021
Closed
@JJKylee
Copy link

JJKylee commented Jan 31, 2021 •
edited
Loading

Thanks for this new filter.

BTW, looking at the inline help for --vpp-warpsharp, I've found this explanation that the default value for type is set to 2:

type=<int>                blur type, 0...13x13, 1...5x5 (default=2)

Isn't it a typo for 0? 🤔

@rigaya
Copy link
Owner

rigaya commented Feb 1, 2021

Thanks, the help is printed wrong, meanwhile please refer to the online doc which is correct.

I'll fix --help in the next release.

@rigaya
Copy link
Owner

rigaya commented Feb 11, 2021

The help was fixed in NVEnc 5.27.

   --vpp-warpsharp [<param1>=<value>][,<param2>=<value>][...]
     warpsharp filter to enhance edge.
    params
      threshold=<float>         edge mask threshold (default=128.0, 0-255)
      blur=<int>                number of times to blur the edge mask.
                                  (default=2, 0-)
      type=<int>                blur type, 0...13x13, 1...5x5 (default=0)
      depth=<float>             how far to warp (default=16.0, -128 - 128)
      chroma=<int>              0...use luma mask, 1...create chroma mask
                                  (default=0)

@rigaya rigaya closed this as completed Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rigaya @JJKylee @GregAlanR