Uncurried mode #5796
Merged
Uncurried mode #5796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2022
cristianoc
commented
Nov 12, 2022
| @@ -140,5 +140,5 @@ let c1 = @foo x => @bar y => x + y | |||
| let c2 = (. x) => {y => x + y} | |||
| let c3 = (. x) => {@foo y => x + y} | |||
|
|
|||
| type t1 = (. int, string) => bool | |||
| type t1 = (. int) => string => bool | |||
There was a problem hiding this comment.
This change is a fix.
cristianoc
commented
Nov 12, 2022
| @@ -9,8 +9,8 @@ type nonrec t = | |||
| type nonrec t = | |||
| (((float -> | |||
| ((int)[@attr2 ]) -> | |||
| (((bool -> ((string)[@attr4 ]) -> unit) Js.Fn.arity2)[@attr3 ])) | |||
| Js.Fn.arity2)[@attr ]) | |||
| (((bool -> ((string)[@attr4 ]) -> unit) Js.Fn.arity1)[@attr3 ])) | |||
There was a problem hiding this comment.
This change is a fix.
cristianoc
commented
Nov 12, 2022
|
|
||
| let cFun = (. x) => 3 | ||
| let uFun = x => 3 | ||
| let mixFun = (.a) => (b, c) => (.d, e, f) => (.g) => h => 4 |
There was a problem hiding this comment.
This is an example that cannot be written in uncurried mode by simply flipping the first dots. But it can after normalising.
The corner case has the form:
```res
(x, .y) => z => 3
```
The dot in the middle of a sequence of args does not have a corresponding form in uncurried by default, because non-dots in uncurried by defaults are the normal ways to express the argument after the first.
This means there's asymmetry between the two syntaxes.
This could be handled by declaring this syntax invalid.
Currently we instead parse to the desugaring of the syntax, which in normal mode is:
```res
x => (.y) => { z => 3 }
```
And in uncurried mode is expressed as:
```res
(.x) => y => { (. z) => 3 }
```
E.g. `(. int) => string => bool`
cristianoc
force-pushed
the
uncurried_mode
branch
from
9bf6a52 to
8bac9a8
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.